douying9296 2017-08-29 20:59
浏览 212
已采纳

Base64编码/解码导致输出损坏

I'm trying to write some convenience wrapper funcs that base64 encodes and decodes byte slices. (Can't understand why this is not conveniently provided in the stdlib.)

However this code (in playground):

func b64encode(b []byte) []byte {
    encodedData := &bytes.Buffer{}
    encoder := base64.NewEncoder(base64.URLEncoding, encodedData)
    defer encoder.Close()
    encoder.Write(b)
    return encodedData.Bytes()
}

func b64decode(b []byte) ([]byte, error) {
    dec := base64.NewDecoder(base64.URLEncoding, bytes.NewReader(b))
    buf := &bytes.Buffer{}
    _, err := io.Copy(buf, dec)
    if err != nil {
        return nil, err
    }
    return buf.Bytes(), nil
}


func main() {
    b := []byte("hello")
    e := b64encode(b)
    d, err := b64decode(e)
    if err != nil {
        log.Fatalf("could not decode: %s", err)
    }
    fmt.Println(string(d))
}

generates truncated output when I try to print it:

hel

What's going on?

  • 写回答

1条回答 默认 最新

  • duankan8739 2017-08-29 21:02
    关注

    The defer executes when the function ends. That is AFTER the return statement has been evaluated.

    The following works: https://play.golang.org/p/sYn-W6fZh1

    func b64encode(b []byte) []byte {
        encodedData := &bytes.Buffer{}
        encoder := base64.NewEncoder(base64.URLEncoding, encodedData)
        encoder.Write(b)
        encoder.Close()
        return encodedData.Bytes()
    }
    

    That being said, if it really is all in memory, you can avoid creating an encoder entirely. Instead, you can do something like:

    func b64encode(b []byte) []byte {
        ret := make([]byte, base64.URLEncoding.EncodedLen(len(b)))
        base64.URLEncoding.Encode(ret, b)
        return ret
    }
    

    An added benefit of doing it this way it it is more efficient since it only needs to allocate once. It also allows you to no longer ignore errors in the Write and Close methods.

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥15 求差集那个函数有问题,有无佬可以解决
  • ¥15 【提问】基于Invest的水源涵养
  • ¥20 微信网友居然可以通过vx号找到我绑的手机号
  • ¥15 寻一个支付宝扫码远程授权登录的软件助手app
  • ¥15 解riccati方程组
  • ¥15 display:none;样式在嵌套结构中的已设置了display样式的元素上不起作用?
  • ¥15 使用rabbitMQ 消息队列作为url源进行多线程爬取时,总有几个url没有处理的问题。
  • ¥15 Ubuntu在安装序列比对软件STAR时出现报错如何解决
  • ¥50 树莓派安卓APK系统签名
  • ¥65 汇编语言除法溢出问题