douqie1816 2018-06-13 18:56
浏览 37
已采纳

我应该在程序包级别但在http处理程序之外声明变量吗?

I'm using gin gonic as http framework and I need to group some paths with shared variable by like this:

ur := r.Group("/")
ur.Use(package.Prepare)
{
    ur.GET("/", package.Home)
}

Inside the Prepare handler, I declare package variable like package.tplPath because I want all sub routes can access to this variable instead of rewrite the code in each http handler.

var tplPath = ""

func Prepare(c *gin.Context) {
    _, filename, _, _ := runtime.Caller(0)
    s := helper.RelativeFilePath(filename)
    tplPath = s[1:len(s)] + "template/"
}

I don't know how Go works with each process, and variables for each http request. If a variable was declared in package level, will it be set after each http request?

Is this considered good practice? If not, why not?

  • 写回答

2条回答 默认 最新

  • dongliao3742 2018-06-13 19:03
    关注

    This is not threadsafe, package variables are shared across all goroutines, and modification in one routine will change the value in all the others, causing a data race.

    In general; try and avoid using package level variables where possible.

    Edit:

    In go, packages are a kind of module. There exists only one instance of a package for any given import path (basically package name). This means that there is only 1 instance of any variable at package level.

    Package variables are shared, global state. All accessors of that variable will be accessing the exact same memory.

    It does not matter what type the package variable is, struct / string / int etc. If it is defined at package level, all accessors of that variable will share the same instance of it.

    If (as with http servers) you have concurrent code, there will be multiple accessors of that variable at the same time. In some situations this is fine, like when that variable is only ever read, but it appears that in your case it will be modified. Making this code racy!

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(1条)

报告相同问题?

悬赏问题

  • ¥15 phython读取excel表格报错 ^7个 SyntaxError: invalid syntax 语句报错
  • ¥20 @microsoft/fetch-event-source 流式响应问题
  • ¥15 ogg dd trandata 报错
  • ¥15 高缺失率数据如何选择填充方式
  • ¥50 potsgresql15备份问题
  • ¥15 Mac系统vs code使用phpstudy如何配置debug来调试php
  • ¥15 目前主流的音乐软件,像网易云音乐,QQ音乐他们的前端和后台部分是用的什么技术实现的?求解!
  • ¥60 pb数据库修改与连接
  • ¥15 spss统计中二分类变量和有序变量的相关性分析可以用kendall相关分析吗?
  • ¥15 拟通过pc下指令到安卓系统,如果追求响应速度,尽可能无延迟,是不是用安卓模拟器会优于实体的安卓手机?如果是,可以快多少毫秒?