在上传到服务器之前重命名文件

Question

I'm trying to create some sort of "selfie" uploader on mobile phones. Now it's working great it's just that when i test the upload file on my iPhone all the photo's will be named image.jpeg so they keep overwriting each other. Now what i want to do is rename the file to let's say image1.jpeg and the next image2.jpeg before it gets uploaded to the server.

My current code:

<?php
if (isset($_FILES['myFile'])) {
move_uploaded_file($_FILES['myFile']['tmp_name'], "uploads/" . $_FILES['myFile']    ['name']);
echo 'successful';
}
?>

I tried this code to give my image a filename value of image plus a random number between 1 and 99999 but this wasn't a succes.

<?php
if (isset($_FILES['myFile'])) {

$temp = explode(".",$_FILES["myFile"]["name"]);
$newfilename = rand(1,99999) . '.' .end($temp);
move_uploaded_file($_FILES["myFile"]["tmp_name"], "uploads/" . $newfilename;
echo 'successful';
}
?>

Any pointers will be appreciated.

Answer 1

this wasn't a succes.

Not a descriptive way to describe your error. Please include PHP errors or investigate them yourself so you (or we) can figure out what problems you're having with your code. Some editors will even tell you where your parsing errors are. You can also use a PHP linter.

The error lies in this line:

move_uploaded_file($_FILES["myFile"]["tmp_name"], "uploads/" . $newfilename;

The move_uploaded_file function is missing a closing bracket, so you must put it back in:

move_uploaded_file($_FILES["myFile"]["tmp_name"], "uploads/" . $newfilename);

I'd also recommend a better random filename generator. Try something like this instead:

$newfilename = sha1(uniqid(mt_rand(), true)) . '.' .end($temp);

It will create a hash that has a much lower likelihood of collisions (read: 1 in 2¹⁶⁰.)

Best of luck!