为什么连接使用包含一次失败与pdo失败？

Question

Why Connecting using include once is failing with pdo?
When I connect to the database including a connection page it gave me an error, but when I put the connecting code in and I remove include I do not get errors. What might be the problem?

Error Fatal error: Call to a member function prepare() on a non-object in C:\wamp\www\tish\A\view.php on line 167

Connecting page:

<?php
  function connected_Db(){
    try {
      $con = new PDO('mysql:host=localhost;dbname=tish_database;charset=utf8','root','');
    } catch(PDOException $e){
      echo 'Connection failed'.$e->getMessage();
    }
  }
  connected_Db();
?>

the way I include it in other pages:

include_once('pdo.inc.php');
connected_Db();
global $con;

Answer 1

You can't make a function variable global from the global scope. The variable $con has long been GC'ed: it's deallocated once the function has returned. Try this:

function connected_Db()
{
   return new PDO('mysql:host=localhost;dbname=tish_database;charset=utf8','root','');
}
//global scope:
$con = connect_Db();

If you insist on using the global keyword, which is not a great idea, you should've used it like this:

function connected_Db()
{
    global $con;//use the global var, set at top of function
    $con = new PDO('mysql:host=localhost;dbname=tish_database;charset=utf8','root','');
}
$con = null;// declare global var (optional, but a notice will be issued if not declared)
connect_Db();
var_dump($con);

As you can see, I have -like deceze and YourCommonSense suggested- removed the try-catch block (which you don't need here). It also goes to show that you don't really need the function call either. Your script would work perfectly fine (or marginally faster even) if you were to write this:

//global scope (or whatever scope you need it to be)
$con = new PDO('mysql:host=localhost;dbname=tish_database;charset=utf8','root','');

That way, you're not calling a function that needn't be called.