While writing some PHP, I needed to iterate over a function call that could also return null, so I used the following construct:
foreach (($object->method() ? : array()) as $thing)
{
// Insert code here
}
My project manager was not fond of this practice and insisted I write something more verbose. I understand his perspective, but if it were up to me, I would leave it as is. What do others think of this practice?
分享 It's perfectly cromulent. While this will lead to a PHP 5.3 dependency, it's short and still readable. I guess he took exception to its occurence in foreach, where complex expressions are somewhat uncommon, and hencewhy frowned upon.
Anyway, I sometimes use casting there, which is not more readable, but useful for parameter flexibility (treating a single string as array), not sure if that's really "better" in this case:
foreach ( (array)$object->method() as $xy )
{
Obviously, only works if the method returns nothing (NULL). If you can help it, make the method itself return an empty array instead (as good as a boolean false).
分享
