doujiabing1228 2017-12-22 11:32
浏览 401
已采纳

重置golang中的错误是否是错误的做法?

When parsing a string as text, I want any non-parseable string to result in a zero time and then carry on.

passwordLastUsed, err = time.Parse(time.RFC3339, record[lastUsed])
if err != nil {
    err = nil
    passwordLastUsed = time.Time{}
}

This code looks a bit messy and the 'ineffassign' linter returns this for the 'err = nil' statement:

warning: ineffectual assignment to err (ineffassign)

Is there a better way of handling this or should I just ignore the linter?

  • 写回答

1条回答 默认 最新

  • doupu5941 2017-12-22 11:44
    关注

    It's not bad practice to reset an error variable, if that's what you want to do.

    It is bad practice to set variables that aren't used later--and that's what the warning is about.

    There's probably never a reason to reset an error as you are doing, since after the if block err will always be nil.

    It does make sense if you're only resetting in some cases. A common example:

    result, err := db.Query(...)
    if err == sql.ErrNoRows {
        err = nil // Ignore not-found rows
    }
    if err != nil {
        return err // But return all other errors
    }
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥20 求一个html代码,有偿
  • ¥100 关于使用MATLAB中copularnd函数的问题
  • ¥20 在虚拟机的pycharm上
  • ¥15 jupyterthemes 设置完毕后没有效果
  • ¥15 matlab图像高斯低通滤波
  • ¥15 针对曲面部件的制孔路径规划,大家有什么思路吗
  • ¥15 钢筋实图交点识别,机器视觉代码
  • ¥15 如何在Linux系统中,但是在window系统上idea里面可以正常运行?(相关搜索:jar包)
  • ¥50 400g qsfp 光模块iphy方案
  • ¥15 两块ADC0804用proteus仿真时,出现异常