dongnaizao8039 2018-05-03 13:57
浏览 21
已采纳

处理两个连续的错误

While reading a code, I ran into the following error handling currently implemented in the code:

    nodes, err := model.AllNodes()
    links, err := model.AllLinks()
    if err != nil {
        // Do stuff
    }

I'm curious to know if the above error handling can create unpredictable results. I have this alternative in mind:

    nodes, err1 := model.AllNodes()
    if err1 != nil {
        // Do stuff
    }
    links, err2 := model.AllLinks()
    if err2 != nil {
        // Do stuff
    }

Or maybe this:

    nodes, err1 := model.AllNodes()
    links, err2 := model.AllLinks()
    if err1 != nil || err2 != nil {
        // Do stuff
    }

I'm not sure, please help me to know if the current implemented error handling can cause a bug. Please let me know if there is a better alternative. Thanks.

  • 写回答

1条回答 默认 最新

  • dsk88199 2018-05-03 14:01
    关注

    You are right to be concerned. The first error is not being handled at all, which is probably a bug. If the author intended not to check that error, it would be much more clear to do so explicitly:

    nodes, _ := model.AllNodes()
    links, err := model.AllLinks()
    if err != nil {
        // Do stuff
    }
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?