douye1940 2017-09-24 11:34
浏览 81
已采纳

linter发出的goconst警告

I'm using Atom to develop my Go app. The Linter in Atom is reporting an odd warning, and I don't see how it's a problem. Should I forever ignore the warning, or is there an alternate method I can implement?

I have a routes like so, in a file "app.go":

a.Router.HandleFunc("/login", a.PageLogin)
a.Router.HandleFunc("/register", a.PageRegister)
a.Router.HandleFunc("/event/add", a.PageEventCreate)

In my "routes_pages.go" file, I have funcs defined like so:

func (a *App) PageEventCreate(w http.ResponseWriter, r *http.Request) {

    switch r.Method {
        case "GET":
            // Serve the resource.
        case "POST":
            // Create a new record.
        case "PUT":
            // Update an existing record.
        case "DELETE":
            // Remove the record.
        default:
            // Give an error message.
    }

}



func (a *App) PageLogin(res http.ResponseWriter, req *http.Request) {
        switch r.Method {
            case "GET":
                // Serve the resource.
            case "POST":
                // Create a new record.
            case "PUT":
                // Update an existing record.
            case "DELETE":
                // Remove the record.
            default:
                // Give an error message.
        }

}

I have a multitude of funcs setup this way. It makes it easy to work on any case (GET, POST, etc) in one place.

The Linter in Atom has a problem with this. It's reporting a warning for each item, for example:

Warning goconst 3 other occurrence(s) of "GET" found in: routes_pages.go:384:8 routes_pages.go:443:7 routes_pages.go:536:7 (goconst)    198:8

This warning occurs many times; once for every instance of switch/case with GET, PUT, DELETE, etc; a huge list.

I see no apparent way to 'ignore' the warning in Atom, so I feel like just disabling the linter, which is not great for more serious warnings...

  • 写回答

1条回答 默认 最新

  • doukuai3822 2017-09-24 11:46
    关注

    It's just a warning that you're re-using the same string literal in multiple places. This can be problematic because string literals are liable to be misspelled without noticing. The solution is to use a constant instead. This is made very easy in your case, because all of the (standard) HTTP verbs are already constants exported by the http package. Just update your string literals to use the contant version instead:

    func (a *App) PageLogin(res http.ResponseWriter, req *http.Request) {
            switch r.Method {
                case http.MethodGet:
                    // Serve the resource.
                case http.MethodPost:
                    // Create a new record.
                case http.MethodPut:
                    // Update an existing record.
                case http.MethodDelete:
                    // Remove the record.
                default:
                    // Give an error message.
            }
    }
    

    By using a constant, you safeguard against an accidental typo. Example:

    req, err := http.NewRequest("DLETE", ...)
    

    would not result in a compile-time error (and may not even result in a runtime error, depending on the rest of your program's logic), but

    req, err := http.NewRequest(http.MethodDlete, ...)
    

    will fail to compile.

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥15 Arcgis相交分析无法绘制一个或多个图形
  • ¥15 seatunnel-web使用SQL组件时候后台报错,无法找到表格
  • ¥15 fpga自动售货机数码管(相关搜索:数字时钟)
  • ¥15 用前端向数据库插入数据,通过debug发现数据能走到后端,但是放行之后就会提示错误
  • ¥30 3天&7天&&15天&销量如何统计同一行
  • ¥30 帮我写一段可以读取LD2450数据并计算距离的Arduino代码
  • ¥15 飞机曲面部件如机翼,壁板等具体的孔位模型
  • ¥15 vs2019中数据导出问题
  • ¥20 云服务Linux系统TCP-MSS值修改?
  • ¥20 关于#单片机#的问题:项目:使用模拟iic与ov2640通讯环境:F407问题:读取的ID号总是0xff,自己调了调发现在读从机数据时,SDA线上并未有信号变化(语言-c语言)