dougu4704
2017-12-21 09:52 阅读 134
已采纳

如何使用带有可变数量参数的go-sqlmock WithArgs()?

I use go-sqlmock (https://godoc.org/github.com/DATA-DOG/go-sqlmock) to test a function that receives a variable number of arguments (I simplified the function for the sake of simplicity and stripped out most of the code):

func getHits(db *sql.DB, actions ...string) (hits []Hit, err error) {
   // ...
   query := `select * from table where action in (?,?)`
   rows, err := db.Query(query, actions)
   // ...
}

The tests look like that:

// rows := ...
actions := []string{"click", "event"}
mock.ExpectQuery(`^select .*`).WithArgs(actions).WillReturnRows(rows)
hits, err := getHits(db, actions...)
if mockErr := mock.ExpectationsWereMet(); mockErr != nil {
    log.Fatalf("there were unfulfilled expections: %s", mockErr)
}

Then I get this output:

2017/12/21 10:38:23 there were unfulfilled expections: there is a remaining expectation which was not matched: ExpectedQuery => expecting Query or QueryRow which:
- matches sql: '^select .*'
- is with arguments:
  0 - [click event]
- should return rows: ...

If I change the tests like this:

mock.ExpectQuery(`^select .*`).WithArgs(actions[0], actions[1]).WillReturnRows(rows)

Then I get this output:

2017/12/21 10:44:41 there were unfulfilled expections: there is a remaining expectation which was not matched: ExpectedQuery => expecting Query or QueryRow which:
- matches sql: '^select .*'
- is with arguments:
  0 - click
  1 - event
- should return rows:

The only I can make it pass is by calling :

db.Query(query, actions[0], actions[1])

which is what I obviously don't want to do as I don't know the number of actions...

Does anyone have an idea on how I could fix or debug this ?

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

2条回答 默认 最新

  • 已采纳
    dozpox8752 dozpox8752 2017-12-21 14:34

    I found a way to fix my problem : If I convert the slice of strings to a slice of interfaces for db.Query, it works just fine:

    boundValues := make([]interface{}, len(actions))
    
    for i, val := range actions {
        boundValues[i] = val
    }
    
    rows, err := db.Query(query, boundValues...)
    

    Then for the tests:

    mock.ExpectQuery(`^select .*`).WithArgs(actions[0], actions[1]).WillReturnRows(rows)
    

    NOTE: passing just db.Query(query, actions...) does not work; this results in cannot use actions (type []string) as type []interface {} in argument to db.Query

    点赞 评论 复制链接分享
  • dtqscvrzn968518698 dtqscvrzn968518698 2018-03-16 08:28

    Accepted answer using []interface{} would work for string but it can throw an error for other types.

    Short answer

    actions := []driver.Value{"click", "event"}
    mock.ExpectQuery(`^select .*`).WithArgs(actions...).WillReturnRows(rows)
    

    Long answer

    The argument requires driver.Value reference and driver.Value can be one of these types:

    • int64
    • float64
    • bool
    • []byte
    • string
    • time.Time

    so, the correct answer is

    actions := []driver.Value{"click", "event"}
    mock.ExpectQuery(`^select .*`).WithArgs(actions...).WillReturnRows(rows)
    
    点赞 评论 复制链接分享

相关推荐