duancheng7743 2013-11-10 17:29
浏览 30
已采纳

所有goroutine都在睡觉-死锁

For one of my requirement I have to create N number of worker go routines, which will be monitored by one monitoring routine. monitoring routine has to end when all worker routines completes. My code ending in deadlock, please help.

import "fmt"
import "sync"
import "strconv"

func worker(wg *sync.WaitGroup, cs chan string, i int ){
    defer wg.Done()
    cs<-"worker"+strconv.Itoa(i)    
}

func monitorWorker(wg *sync.WaitGroup, cs chan string) {
    defer wg.Done()
    for i:= range cs {
            fmt.Println(i)
     }
}
func main() {
    wg := &sync.WaitGroup{}
    cs := make(chan string)

    for i:=0;i<10;i++{
             wg.Add(1)
             go worker(wg,cs,i)
    } 

    wg.Add(1)
    go monitorWorker(wg,cs)
    wg.Wait()
}
  • 写回答

2条回答 默认 最新

  • dongsi4815 2013-11-10 17:52
    关注

    Your monitorWorker never dies. When all the workers finish, it continues to wait on cs. This deadlocks because nothing else will ever send on cs and therefore wg will never reach 0. A possible fix is to have the monitor close the channel when all workers finish. If the for loop is in main, it will end the loop, return from main, and end the program.

    For example: http://play.golang.org/p/nai7XtTMfr

    package main
    
    import (
        "fmt"
        "strconv"
        "sync"
    )
    
    func worker(wg *sync.WaitGroup, cs chan string, i int) {
        defer wg.Done()
        cs <- "worker" + strconv.Itoa(i)
    }
    
    func monitorWorker(wg *sync.WaitGroup, cs chan string) {
        wg.Wait()
        close(cs)
    }
    
    func main() {
        wg := &sync.WaitGroup{}
        cs := make(chan string)
    
        for i := 0; i < 10; i++ {
            wg.Add(1)
            go worker(wg, cs, i)
        }
    
        go monitorWorker(wg, cs)
    
        for i := range cs {
            fmt.Println(i)
    
        }
    }
    

    Edit: This is an answer to OP's first comment.

    Your program has three parts that need to synchronize. First, all of your workers need to send the data. Then your print loop needs to print that data. Then your main function needs to return thereby ending the program. In your example, all the workers send the data, all the data gets printed, but the message is never sent to main that it should return gracefully.

    In my example, main does the printing and "monitorWorker" just tells main when it has received every piece of data it needs to print. This way the program ends gracefully and not by deadlock.

    If you insist on the print loop being in another goroutine, you can do that. But then an extra communication needs to be sent to main so it returns. In this next example, I use a channel to ensure main ends when all data is printed.

    package main
    
    import (
        "fmt"
        "strconv"
        "sync"
    )
    
    func worker(wg *sync.WaitGroup, cs chan string, i int) {
        defer wg.Done()
        cs <- "worker" + strconv.Itoa(i)
    }
    
    func monitorWorker(wg *sync.WaitGroup, cs chan string) {
        wg.Wait()
        close(cs)
    }
    
    func printWorker(cs <-chan string, done chan<- bool) {
        for i := range cs {
            fmt.Println(i)
        }
    
        done <- true
    }
    
    func main() {
        wg := &sync.WaitGroup{}
        cs := make(chan string)
    
        for i := 0; i < 10; i++ {
            wg.Add(1)
            go worker(wg, cs, i)
        }
    
        go monitorWorker(wg, cs)
    
        done := make(chan bool, 1)
        go printWorker(cs, done)
        <-done
    }
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(1条)

报告相同问题?

悬赏问题

  • ¥15 file converter 转换格式失败 报错 Error marking filters as finished,如何解决?
  • ¥15 ubuntu系统下挂载磁盘上执行./提示权限不够
  • ¥15 Arcgis相交分析无法绘制一个或多个图形
  • ¥15 关于#r语言#的问题:差异分析前数据准备,报错Error in data[, sampleName1] : subscript out of bounds请问怎么解决呀以下是全部代码:
  • ¥15 seatunnel-web使用SQL组件时候后台报错,无法找到表格
  • ¥15 fpga自动售货机数码管(相关搜索:数字时钟)
  • ¥15 用前端向数据库插入数据,通过debug发现数据能走到后端,但是放行之后就会提示错误
  • ¥30 3天&7天&&15天&销量如何统计同一行
  • ¥30 帮我写一段可以读取LD2450数据并计算距离的Arduino代码
  • ¥15 飞机曲面部件如机翼,壁板等具体的孔位模型