duang8642 2017-03-01 01:06 采纳率: 0%
浏览 48
已采纳

无法使用使用范围的变量

I have written a simple script that will read the /proc/cpuinfo and return a []map[string]string containing the info about the cores.

The problem is I am unable to use the values inside the range it always gives me the info of the last CPU.

I tried using closures literally everywhere with no success. And also I tried to copy the variables locally in the loop and still no success.

Here is my code

func GetCpuInfo() CpuInfo {
    cpus, err := os.Open("/proc/cpuinfo")
    if err != nil {
        log.Fatalln("Cannot open /proc/cpuinfo")
    }
    defer cpus.Close()
    s := bufio.NewScanner(cpus)
    cpuCores := make(CpuCores, 0)
    core := map[string]string{}
    for s.Scan() {
        txt := s.Text()
//copying the variable also does not work
        core := core

        if len(txt) == 0 {
//tried to use closure here with no success
            cpuCores = append(cpuCores, core)
            continue
        }
        fields := strings.Split(txt, ":")
        if len(fields) < 2 {
            continue
        }
//using closure here wont work either
        var k, v = strings.TrimSpace(fields[0]), strings.TrimSpace(fields[1])
        core[k] = v
    }
    return CpuInfo{
        Cores:    cpuCores,
        CpuCount: uint(runtime.NumCPU()),
        Brand:    cpuCores[0]["vendor_id"],
        Model:    cpuCores[0]["model name"],
    }
}

As you see from the code seems like there is no way to use this variable or i am really missing some huge point.

  • 写回答

3条回答 默认 最新

  • dongyi9082 2017-03-02 21:03
    关注

    I just found the way around by resetting the core variable after appending it

    if len(txt) == 0 {
                    cpuCores = append(cpuCores, core)
                    core=map[string]string{}
                }
    

    like this but I am not sure if this can cause a memory leak

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(2条)

报告相同问题?