weixin_39610785
weixin_39610785
2020-11-29 20:49

ratpack-groovy-test shouldn't depend on ratpack-remote

I don't know what I was thinking when implementing this. The dependency should be removed and RemoteControlUsageSpec should be moved to ratpack-remote.

该提问来源于开源项目:ratpack/ratpack

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39728221 weixin_39728221 4月前

    Why should that spec be moved to core?

    点赞 评论 复制链接分享
  • weixin_39610785 weixin_39610785 4月前

    Not core. I mistyped it and then edited it to say ratpack-remote.

    点赞 评论 复制链接分享
  • weixin_39728221 weixin_39728221 4月前

    Can you please check that the books app example still works, and update it if not.

    点赞 评论 复制链接分享
  • weixin_39728221 weixin_39728221 4月前

    We really must get the example apps incorporated into the build sooner rather than later.

    点赞 评论 复制链接分享
  • weixin_39610785 weixin_39610785 4月前

    As part of checking that it still works, should I bring it into the main repo? Inside of examples directory? Are we ok with loosing history for example apps?

    点赞 评论 复制链接分享
  • weixin_39728221 weixin_39728221 4月前

    Let's move this discussion #18.

    点赞 评论 复制链接分享