weixin_39540934 2020-11-20 15:11
浏览 0

Enhancing to allow override of default dashboard template

here you go supporting https://github.com/DataTorrent/malhar-angular-dashboard/issues/34

该提问来源于开源项目:dtpublic/malhar-angular-dashboard

  • 写回答

4条回答 默认 最新

  • weixin_39540934 2020-11-20 15:11
    关注

    Hi Andy,

    Certainly agree that repeating all tests is too much...just the five or so here would want to be repeated per template: https://github.com/DataTorrent/malhar-angular-dashboard/blob/master/test/spec/angular-ui-dashboard.js#L58-81

    If we are going to be checking for random bits of DOM I liked your approach with hardcoding them in templateCache and test, but if we want multiple we may have to add more...here is ours for now:

    https://github.com/awashbrook/angular-ui-dashboard/blob/master/template/alt-dashboard.html

    There isn't easy (yet) to distinguish from your default, maybe I should add class="widget-container custom-widget or similar to help, what do you think?

    评论

报告相同问题?