weixin_39649611
weixin_39649611
2020-11-21 19:17

Clang-tidy checks for Validation

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this tomorrow to avoid conflicts to the extent possible]

该提问来源于开源项目:cms-sw/cmssw

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39962889 weixin_39962889 5月前

    The code-checks are being triggered in jenkins.

    点赞 评论 复制链接分享
  • weixin_39962889 weixin_39962889 5月前

    +code-checks

    Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20794/1236

    点赞 评论 复制链接分享
  • weixin_39962889 weixin_39962889 5月前

    A new Pull Request was created by (David Lange) for master.

    It involves the following packages:

    Validation/CSCRecHits Validation/CaloTowers Validation/CheckOverlap Validation/DTRecHits Validation/EcalClusters Validation/EcalDigis Validation/EcalHits Validation/EcalRecHits Validation/EcalTriggerPrimitives Validation/EventGenerator Validation/Geometry Validation/GlobalDigis Validation/GlobalHits Validation/GlobalRecHits Validation/HGCalValidation Validation/HcalDigis Validation/HcalHits Validation/HcalRecHits Validation/Mixing Validation/MuonCSCDigis Validation/MuonDTDigis Validation/MuonGEMDigis Validation/MuonGEMHits Validation/MuonGEMRecHits Validation/MuonHits Validation/MuonIdentification Validation/MuonIsolation Validation/MuonME0Validation Validation/MuonRPCDigis Validation/MuonRPCGeometry Validation/Performance Validation/RPCRecHits Validation/RecoB Validation/RecoEgamma Validation/RecoHI Validation/RecoJets Validation/RecoMET Validation/RecoMuon Validation/RecoParticleFlow Validation/RecoTau Validation/RecoTrack Validation/RecoVertex Validation/SiPixelPhase1DigisV Validation/SiPixelPhase1HitsV Validation/SiPixelPhase1RecHitsV Validation/SiPixelPhase1TrackClustersV Validation/SiPixelPhase1TrackingParticleV Validation/TrackerDigis Validation/TrackerHits Validation/TrackerRecHits Validation/TrackingMCTruth

    , , , , , , , , , , , , , , , can you please review it and eventually sign? Thanks. , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , this is something you requested to watch as well. , you are the release manager for this.

    cms-bot commands are listed here

    点赞 评论 复制链接分享
  • weixin_39649611 weixin_39649611 5月前

    please test

    点赞 评论 复制链接分享
  • weixin_39962889 weixin_39962889 5月前

    The tests are being triggered in jenkins. https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23534/console Started: 2017/10/07 14:43

    点赞 评论 复制链接分享
  • weixin_39962889 weixin_39962889 5月前

    -1

    Tested at: 6a4cbfe7f69ffe667b0d94501c08e6e97e57bcef

    The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: https://github.com/cms-sw/cmssw/commit/a37ee8e470f65ce013b015412dfac12321c7e4ce You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20794/23534/git-log-recent-commits https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20794/23534/git-merge-result

    You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20794/23534/summary.html

    I found follow errors while testing this PR

    Failed tests: RelVals

    • RelVals:

    When I ran the RelVals I found an error in the following worklfows: 10024.0 step5

    runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log
    
    

    The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: https://github.com/cms-sw/cmssw/commit/a37ee8e470f65ce013b015412dfac12321c7e4ce You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20794/23534/git-log-recent-commits https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20794/23534/git-merge-result

    点赞 评论 复制链接分享
  • weixin_39962889 weixin_39962889 5月前

    Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

    点赞 评论 复制链接分享

相关推荐