weixin_39623620
weixin_39623620
2020-11-21 20:07

Remove NULL check for Self() in TreeTop::join

OMR::TreeTop::join() checks if self() is NULL [1], which is odd because it never makes sense to call a member function on a NULL object. Such calls are undefined behaviour.

Closes: #4835 Signed-off-by: Tucker

该提问来源于开源项目:eclipse/omr

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

10条回答

  • weixin_39600400 weixin_39600400 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    please ensure you have signed the ECA and that you sign your commits - see the contributing guide in the docs directory for details.

    点赞 评论 复制链接分享
  • weixin_39623620 weixin_39623620 5月前

    Sorry about that, should be all good now.

    点赞 评论 复制链接分享
  • weixin_39926311 weixin_39926311 5月前

    thanks for your first contribution. The ECA check has failed again due to the merge commit added to the branch (8bddb1e). The ECA requires that every commit be signed off. The fix is simple. Just squash the entire change into a single commit.

    The commit message could be improved slightly [1] to be consistent with the rest of the contributions. Here is a potential example in imperative mood:

    
    Remove NULL check for Self() in TreeTop::join
    
    `OMR::TreeTop::join()` checks if self() is NULL [1], which is odd
    because it never makes sense to call a member function on a NULL
    object. Such calls are undefined behaviour.
    
    Closes: #4835
    Signed-off-by: Tucker <tmiles7.utk.edu>
    </tmiles7.utk.edu>

    Once we get that fixed up and all the checks pass I'll kick off a test build and we'll get the change merged. Thanks!

    [1] https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines

    点赞 评论 复制链接分享
  • weixin_39623620 weixin_39623620 5月前

    Thank you and others for being so helpful, I believe I have successfully squashed the commits and strengthened my commit message.

    点赞 评论 复制链接分享
  • weixin_39926311 weixin_39926311 5月前

    we're almost there. There seems to be some foreign commits added to this PR as part of your rebase.

    点赞 评论 复制链接分享
  • weixin_39623620 weixin_39623620 5月前

    I believe I have cleared this up

    点赞 评论 复制链接分享
  • weixin_39623620 weixin_39623620 5月前

    ECA sign-off status seems to not be getting validated. Making sure my emails are consolidated now

    点赞 评论 复制链接分享
  • weixin_39623620 weixin_39623620 5月前

    All checks seem to pass now!

    点赞 评论 复制链接分享
  • weixin_39926311 weixin_39926311 5月前

    -omr build all

    点赞 评论 复制链接分享

相关推荐