introduce "group" structs in place of query structs

Question

Now that we have converted from macro-rules macros to procedural macros (#108, #118), the next step in implementing https://github.com/salsa-rs/salsa-rfcs/pull/1 is probably to try and convert from the current setup, where we have a "struct per query", to the setup of a "struct per query group that is described in the RFC.

I'll try to update the issue with a vague plan in a bit.

该提问来源于开源项目：salsa-rs/salsa

Answer 1

As a first step we can push more of the details into the query group without making the full transition:

• [ ] We need to create the group descriptor enum from salsa::query_group
• [x] We need to create the group descriptor storage struct from salsa::query_group
• [x] Modify the DatabaseStorageTypes impl so that the storage type is a tuple of the group storage
• [x] Modify the existing GetStorageTable implementations so that they access the query data using storage().N.#query where N is the index of the group in the list, instead of the storage().#query that they use today.

I think if we make those changes, everything should still work as it does today but we are closer to the new design.