Canceled queries are not removed from the database after revision bump

Question

I am seeing canceled queries in Rust analyzer, and I want to blame salsa for them, though I am not sure :-)

Here's the code where I am seeing the issue:

https://github.com/rust-analyzer/rust-analyzer/commit/54c89073b2e6b3abb74f6b2695a31a4f94a50d66

The most interesting file is the log. In the log, we see a single query which is canceled:

https://github.com/rust-analyzer/rust-analyzer/blob/54c89073b2e6b3abb74f6b2695a31a4f94a50d66/log/ra_lsp_server_2018-10-25_15-49-51.log#L9

Here's the source of the log entry.

And, at a much higher revisions, we see that some quires return an Err(Canceled) result:

https://github.com/rust-analyzer/rust-analyzer/blob/54c89073b2e6b3abb74f6b2695a31a4f94a50d66/log/ra_lsp_server_2018-10-25_15-49-51.log#L588-L591

该提问来源于开源项目：salsa-rs/salsa

Answer 1

Looks like the issue is fixed in master. Here's the test for 0.6.0, which triggers the issue:

https://github.com/matklad/salsa/commit/9e84bd0625253c570f262f71f2b68bc07efe6ba6