weixin_39737233
weixin_39737233
2020-11-22 01:50

Move sleep to start of main loop in core.py

By moving the sleep from the end of the main loop to the beginning we allow more modules to have provided output when we first display. This makes the initial display when we Mod+Shift+R etc much smoother.

该提问来源于开源项目:ultrabug/py3status

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

11条回答

  • weixin_39980903 weixin_39980903 5月前

    I must say I've considered this and I thought it was best to output as fast as possible than having a small but still palpable blank time on the bar. Then you see your other modules appearing as they output which also looked more interactive to me.

    I'd like some other users' impressions about this since we have a sort of stale feelings here :)

    点赞 评论 复制链接分享
  • weixin_39980903 weixin_39980903 5月前

    ping

    I'd like your user experience and advising on this matter please so we can decide to merge or close this PR ! Thanks

    点赞 评论 复制链接分享
  • weixin_39639049 weixin_39639049 5月前

    I don't have a very strong opinion on this one, but I would slide with on this one. It's nice to see that it's working, and then modules appear. However, I think it can also be disturbing at first that some things appear and not others, so maybe from the point of view of a new user, it would be better to wait until all modules have a output and then display.

    点赞 评论 复制链接分享
  • weixin_39976575 weixin_39976575 5月前

    I tried this branch, and personally I like it more than the current behavior in master.

    But at the same time I think the difference is so negligible that I wouldn't spend too much time arguing for one of the options :)

    How about we have a simple poll? :joystick: - Those who are in favor of merging this pull request, please upvote :+1: the first comment in this thread. - Those who are against merging this pull request, please downvote :-1: it.

    The poll closes on Monday 31.10.2016, so that everyone has weekends ahead to see this notification, and based on the counters either merges or abandons this pull request.

    点赞 评论 复制链接分享
  • weixin_39777404 weixin_39777404 5月前

    I'll pull it down and check here at some point.

    点赞 评论 复制链接分享
  • weixin_39980903 weixin_39980903 5月前

    Ok let's vote :)

    let's bring more possible votes in, friendly ping to

    thanks !

    点赞 评论 复制链接分享
  • weixin_39640221 weixin_39640221 5月前

    Maybe each module can deliver a static init string which is shown the first time on startup when the module is uninitialized. Then we can load the module at the end of the while loop.

    点赞 评论 复制链接分享
  • weixin_39769740 weixin_39769740 5月前

    That actually sounds like a nice idea, I think. +1

    点赞 评论 复制链接分享
  • weixin_39980903 weixin_39980903 5月前

    Maybe each module can deliver a static init string which is shown the first time on startup when the module is uninitialized. Then we can load the module at the end of the while loop.

    I had the idea of having a standardized "loading icon" similar are those we usually see on websites, I'm sure the effect would be awesome :)

    点赞 评论 复制链接分享
  • weixin_39777404 weixin_39777404 5月前

    The way I'd implement this is just to show the entry — so it'd be something like clementine | battery_level | disk /home | static_text

    On 10/29/2016 09:01 AM, Ultrabug wrote:

    
    Maybe each module can deliver a static init string which is shown
    the first time on startup when the module is uninitialized. Then
    we can load the module at the end of the while loop.
    

    I had the idea of having a standardized "loading icon" similar are those we usually see on websites, I'm sure the effect would be awesome :)

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ultrabug/py3status/pull/477#issuecomment-257093303, or mute the thread https://github.com/notifications/unsubscribe-auth/AAghDWAcMO7ZT40fN38p2GeghrUvBmOyks5q41GigaJpZM4J34bI.

    点赞 评论 复制链接分享
  • weixin_39980903 weixin_39980903 5月前

    Thanks everyone for your reports and votes ! merged then :)

    点赞 评论 复制链接分享

相关推荐