I implemented your suggestions. Please tell me, if there is anything else I can improve about it.
The user can select LZO compression which is much faster than LZMA. It should definitely get some more testing before it is used in production ;-) - LZO and LZMA bundles can live in the same repository. You can choose each time you do a backup and your choice only affects the new bundles. - I add a field for the compression type, so the file format is different. Because of the protocol buffers, it should work with existing repositories without any problems and old versions of zbackup should be able to read the files, if they don't use LZO compression. I haven't tested this. - If liblzo2 isn't available, zbackup will be compiled without LZO support. - I have implemented some interfaces that can be used to easily add more compression methods. see compression.hh - This pull request includes dragonroot's suggestions on pull request #8 (which is obsolete, now).
7条回答 默认 最新
- weixin_39938269 2020-11-22 02:26点赞 评论 复制链接分享
- weixin_39623713 2020-11-22 02:26
ping?点赞 评论 复制链接分享
Can you please comment what is left (in your opinion) to do with lzo support? I'm going to merge this if you don't mind.点赞 评论 复制链接分享
Ahh now I see what is left. This patchset simply won't work. Working on fix.点赞 评论 复制链接分享
I'll merge as soon as anyone (me probably) will fix https://github.com/Am1GO/zbackup/issues/1点赞 评论 复制链接分享
- weixin_39938269 2020-11-22 02:26
Well, I'm quite sure that it did work a year ago. Anyway, thanks for fixing it :-)点赞 评论 复制链接分享
It didn't even compile :(点赞 评论 复制链接分享