weixin_39818662
weixin_39818662
2020-11-22 03:12

Modify DeadTreesElimination to support rdbars

A treetop hanging a read barrier can be removed if there is no other real use of the read barrier. Otherwise, the treetop has to be kept to anchor the read barrier.

This change contains 2 parts:

The first part changes trivial DeadTreesElimination to remove the first treetop from trees in the following form:

treetop   
   xrdbari  
anchor    
   =>xrdbari

The second part prevents rdbar hanging under treetop with referenceCount > 1 from being removed.

isssue #2812

Signed-off-by: Yi Zhang

该提问来源于开源项目:eclipse/omr

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

20条回答

  • weixin_39818662 weixin_39818662 5月前

    Memory profile on major benchmarks shows map uses less memory than deque in this case and is 1k bytes more memory per compilation so footprint should be fine. There is no obvious compilation time difference.

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    review approval is a prereq here before I consider merging. I still want to do another pass over the code myself.

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    Given the review from -omr on the specific question I raised - I am happy for this to merge now.

    点赞 评论 复制链接分享
  • weixin_39818662 weixin_39818662 5月前

    this PR is dependent on #2875

    点赞 评论 复制链接分享
  • weixin_39604092 weixin_39604092 5月前

    this PR is dependent on #2875

    If that's the case, this PR should be marked as a WIP until #2875 is merged.

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    #2875 is merged can you rebase and un-WIP so this can be progressed?

    点赞 评论 复制链接分享
  • weixin_39818662 weixin_39818662 5月前

    removed the WIP and rebased on latest build. thanks!

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    Needs a review from

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    friendly ping to review when you get a chance

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    any commnet on the questions above?

    点赞 评论 复制链接分享
  • weixin_39818662 weixin_39818662 5月前

    made changes according to the comment. Thanks!

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    Some performance analysis in terms of compile time and memory usage is needed since this could impact that aspect of the compiler and we should understand that as part of the commit.

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    -omr build all

    点赞 评论 复制链接分享
  • weixin_39704374 weixin_39704374 5月前

    is this a WIP given the last comment asking for some more perf testing ?

    点赞 评论 复制链接分享
  • weixin_39818662 weixin_39818662 5月前

    is this a WIP given the last comment asking for some more perf testing ?

    yes, change it to WIP pending on memory profiling result.

    点赞 评论 复制链接分享
  • weixin_39600400 weixin_39600400 5月前

    any updates?

    点赞 评论 复制链接分享

相关推荐