weixin_39947961
weixin_39947961
2020-11-22 19:01

feat: Add functional test for pipeline token

Context

Currently, users can use the pipeline token. However, no functional tests for feature. Therefore, functional test is required for safe release.

Objective

In this PR, I add feature file of functional test for pipeline token.

References

https://github.com/screwdriver-cd/screwdriver/issues/614

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

该提问来源于开源项目:screwdriver-cd/screwdriver

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39629969 weixin_39629969 5月前

    Coverage Status

    Coverage remained the same at 97.709% when pulling 61a28bacff7c332688c6598b1fba007400125762 on sonic-screwdriver-cd:add-functional-test-pipeline-token into 8b092c90deaae84afa1f701ff6e89b2f6ee020b5 on screwdriver-cd:master.

    点赞 评论 复制链接分享
  • weixin_39783857 weixin_39783857 5月前

    Do we need to add the case that the test will fail when Calvin use pipeline token which does not belongs to him ?

    点赞 评论 复制链接分享
  • weixin_39947961 weixin_39947961 5月前

    It seems better to add test case. So I add test case.

    点赞 评论 复制链接分享
  • weixin_39783857 weixin_39783857 5月前

    It seems better to add test case. So I add test case.

    Thanks! LGTM

    点赞 评论 复制链接分享
  • weixin_39947961 weixin_39947961 5月前

    That’s true. I should have prevented the test from running. I add ` tag for each scenario. In this PR, I do not addstep definition. I add onlyfeature file` .

    点赞 评论 复制链接分享
  • weixin_39947961 weixin_39947961 5月前

    Thank you review and approve. I rebase it.

    点赞 评论 复制链接分享

相关推荐