weixin_39994949
weixin_39994949
2020-11-24 12:59

Enable manual user activation

Re #3208 Assumptions: confirmation not needed; single user activation only. Refactoring: move user activation into user manager; update user controller. TODO: selenium test (ideally, I think).

该提问来源于开源项目:galaxyproject/galaxy

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

15条回答

  • weixin_39994949 weixin_39994949 5月前

    If the activation is turned off, the flag is never checked -> I think the button should be hidden.

    I was about to agree.. But then I thought about it; I don't think we should disable that button if the flag is not set. (1) If the feature is disabled, there will be no new accounts that are not activated - so the button will not be displayed for those. It will only be displayed for non-activate accounts, and non-active accounts can only be possible if the feature (a) is enabled, or (b) has been enabled previously. And in the latter, I think it's convenient to have a button to cleanup after unsetting the flag. And (2): the flag does not disable user activation status - it disables the policy that requires that users must confirm their email address, after which the system activates their account. User status exists regardless of that policy. The button is an admin override for that status. What do you think? (also, I'm not a galaxy admin, so I'm only guessing here)

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 5月前

    I followed your rationale but suspect you might be overthinking it. I don't see a benefit in displaying control elements for features that are explicitly turned off.

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前

    I followed your rationale but suspect you might be overthinking it. I don't see a benefit in displaying control elements for features that are explicitly turned off.

    I might be. OK, I'll figure out how to make that change.

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前

    I can't see a better way to do this. In general, passing the app object may be useful in other scenarios down the road: the app holds the config, and grid elements may need to behave differently based on config settings. ? : this has changed considerably since your approval. EDIT: ping too - just noticed your reaction)

    点赞 评论 复制链接分享
  • weixin_39520149 weixin_39520149 5月前

    Sorry, github wouldn't accept the review comment submission, and now it's attached all wonky. Let me know if the suggestion isn't clear and I can get an example together

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前
    • no worries! I don't see the wonky :) thing, and your comments make sense. I wasn't at all sure adding the arg was the best/only possible way. Will change it. Thanks for reviewing!
    点赞 评论 复制链接分享
  • weixin_39520149 weixin_39520149 5月前

    Ok, cool, just let me know if I can help :) And, thanks for working on the suggestions!

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前

    Updated. Thanks - now I see it's done that way for other operations too.

    点赞 评论 复制链接分享
  • weixin_39520149 weixin_39520149 5月前

    Much better, thank you.

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 5月前

    Thanks !

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前

    Afterthoughts. 1. The activation button is displayed regardless of the value of app.config.user_activation_on. Rationale: option might have been on, then turned off, with account(s) still needing activation. 2. I did not add a "deactivate user" option because I think it's not necessary. If, however, it could be helpful, pls let me know. Same for activating multiple users.

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 5月前

    Rationale: option might have been on, then turned off, with account(s) still needing activation.

    If the activation is turned off, the flag is never checked -> I think the button should be hidden.

    I did not add a "deactivate user"

    +1

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 5月前

    I don't see the second commit in the list or in the files diff. 😕

    点赞 评论 复制链接分享
  • weixin_39994949 weixin_39994949 5月前

    I don't see the second commit in the list or in the files diff. 😕

    What second commit?

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 5月前

    Oh that was just a reference, nevermind. 🤣

    点赞 评论 复制链接分享

相关推荐