weixin_39845206
weixin_39845206
2020-11-25 15:52

move sleep values to constant

As a first step of making sleep values configurable move them to constants.

该提问来源于开源项目:zendesk/ruby-kafka

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39845206 weixin_39845206 5月前

    /cc

    点赞 评论 复制链接分享
  • weixin_39845206 weixin_39845206 5月前

    we can change the key names to whatever you think is better

    点赞 评论 复制链接分享
  • weixin_39942492 weixin_39942492 5月前

    I'd rather move the constant to Kafka::DEFAULT_BACKOFFS. But maybe include the full change in this PR?

    点赞 评论 复制链接分享
  • weixin_39845206 weixin_39845206 5月前

    we can move it to Kafka::DEFAULT_BACKOFFS, that's even better. I would rather create small changes instead of creating a big PR which is hard to review, and if for whatever reason we would have to revert, we would revert things that did not break anything. So it's better to do it in small chunks, at least that's how I do it. Will that work?

    点赞 评论 复制链接分享
  • weixin_39942492 weixin_39942492 5月前

    I prefer full-featured PRs over a ton of small ones. I'm not interested in half the changes – this only makes sense if we go all the way. But extra points for having nice commits that I can go through one at a time!

    点赞 评论 复制链接分享
  • weixin_39845206 weixin_39845206 5月前

    I first wanted to clean it up before creating the actual feature, but we can do it in one PR I guess.

    点赞 评论 复制链接分享
  • weixin_39603476 weixin_39603476 5月前

    Hi , it has been a while. The PR is having some conflicts with the master. Do you have any update on this?

    点赞 评论 复制链接分享
  • weixin_39778106 weixin_39778106 5月前

    Pull request has been marked as stale due to a lack of activity.

    点赞 评论 复制链接分享

相关推荐