weixin_39929566
2020-11-27 06:32 阅读 0

JAVA-1884: Add additional methods from TypeToken to GenericType

For JAVA-1884. I think this is generally useful and is simply a wrapper over TypeToken.getRawType(). I also noticed we were missing getSuperType(), getSubType, and getType, but wasn't sure if we should add those (although would be simple to do), what do you think?

TODO: - [ ] update commit subject and changelog entry

该提问来源于开源项目:datastax/java-driver

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

5条回答 默认 最新

  • weixin_39929566 weixin_39929566 2020-11-27 06:32

    As discussed elsewhere, we decided we might as well add the other methods since it's low effort

    点赞 评论 复制链接分享
  • weixin_39929566 weixin_39929566 2020-11-27 06:32

    Added the following methods overall:

    • getRawType
    • getComponentType
    • getSuperType
    • getSubType
    • getType
    • isArray
    点赞 评论 复制链接分享
  • weixin_39929566 weixin_39929566 2020-11-27 06:32

    Can you rebase on 4.x and add the Nullable / NonNull annotations?

    :+1: will do!

    点赞 评论 复制链接分享
  • weixin_39966602 weixin_39966602 2020-11-27 06:32

    if all your comments have been addressed, can you approve the PR?

    点赞 评论 复制链接分享
  • weixin_39966602 weixin_39966602 2020-11-27 06:32

    I forgot to change the commit message 🤦‍♂️ It's OK, it was not that far off anyway.

    点赞 评论 复制链接分享

相关推荐