weixin_39639568
weixin_39639568
2020-11-27 20:20

Update GetValidatorPerformance to support validator indices

What type of PR is this? Feature

What does this PR do? Why is it needed? Support for getting validator performance response with validator indices to make consistent with other RPC methods

Which issues(s) does this PR fix? https://github.com/prysmaticlabs/prysm/issues/5631

该提问来源于开源项目:prysmaticlabs/prysm

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39945679 weixin_39945679 5月前

    Codecov Report

    Merging #5687 into master will decrease coverage by 0.03%. The diff coverage is 83.72%.

    diff
    @@            Coverage Diff             @@
    ##           master    #5687      +/-   ##
    ==========================================
    - Coverage   59.96%   59.93%   -0.04%     
    ==========================================
      Files         312      312              
      Lines       26190    26207      +17     
    ==========================================
    + Hits        15705    15707       +2     
    - Misses       8349     8360      +11     
    - Partials     2136     2140       +4     
    
    点赞 评论 复制链接分享
  • weixin_39639568 weixin_39639568 5月前

    This is ready for review again!

    点赞 评论 复制链接分享
  • weixin_39697143 weixin_39697143 5月前

    Looks great! Thanks for doing this! :smile:

    点赞 评论 复制链接分享
  • weixin_39946266 weixin_39946266 5月前

    Also revert executable permissions on beacon-chain/rpc/beacon/validators.go

    点赞 评论 复制链接分享
  • weixin_39639568 weixin_39639568 5月前

    
    WORKSPACE 100644 → 100755
    

    Please revert making the workspace file executable.

    Also revert executable permissions on beacon-chain/rpc/beacon/validators.go

    Whoops. Sorry about that. Reverted.

    点赞 评论 复制链接分享
  • weixin_39809175 weixin_39809175 5月前

    PTAL

    点赞 评论 复制链接分享

相关推荐