weixin_39892842
weixin_39892842
2020-11-27 23:29

Allow configuration of PR comments vs code comments

In the previous Slack integration, it was possible to subscribe to comments on issues & pull requests but this wouldn't include comments on lines of code.

When comments are enabled in the new Slack integration, it sends every comment to Slack. Even comments on individual lines of code and even if reviews are not enabled in the integration. This makes the integration far too spammy to have comments enabled.

Ideally it would be nice for comments on code to be a separate configuration setting.

该提问来源于开源项目:integrations/slack

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39852688 weixin_39852688 5月前

    Also it would be nice to be able to select only PR comments or only issue comments. If you look at the code this seems to already be possible, the features just seem to be linked all to one command instead of seperate commands: https://github.com/integrations/slack/blob/master/lib/models/subscription.js#L6-L16

    I have never contributed to an open source proejct before but I guess I could try opening a PR to make these values spererate :D

    点赞 评论 复制链接分享
  • weixin_39875842 weixin_39875842 5月前

    Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

    点赞 评论 复制链接分享
  • weixin_39892842 weixin_39892842 5月前

    Well since there haven't been any updates, I assume this is still an issue. I haven't tried the new integration again but can't see anything new from the docs.

    点赞 评论 复制链接分享
  • weixin_39573981 weixin_39573981 5月前

    This would be super helpful, our use case:

    We have a slack channel “#issues” that’s subscribed to all issues on each repository and nothing else. Ideally this would also include issue comments, but since that would stream in PR comments and friends, it’s too noisy and unnecessary for non-end teams, forcing us to turn it off entirely.

    点赞 评论 复制链接分享
  • weixin_39842271 weixin_39842271 5月前

    Sorry to highjack this thread, but I've been frustrated that the new integration barely does anything that the previous webhook integration did. I'm surprised to see you mention comments because I can't get comments (PRs, code review on individual lines or elsewhere) to show in Slack. I've looked everywhere and can't find any way to set that. What am I missing?

    点赞 评论 复制链接分享
  • weixin_39875842 weixin_39875842 5月前

    Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

    点赞 评论 复制链接分享
  • weixin_39892842 weixin_39892842 5月前

    Unless this has changed, we'll still need to use the old integration for now.

    点赞 评论 复制链接分享
  • weixin_39986466 weixin_39986466 5月前

    I don't see any kind of comments with the new integration.

    点赞 评论 复制链接分享
  • weixin_39980711 weixin_39980711 5月前

    notification of comments isn't enabled by default. You can enable for a repo with /github subscribe <owner>/<repo> comments

    There's some more details about the additional notifications you can enable over here.

    点赞 评论 复制链接分享

相关推荐