weixin_39875754
weixin_39875754
2020-11-28 21:50

Allow editing a suggestion which is under review

The author of the suggestion should be able to edit a suggestion after it has been submitted for review. The reviewer should also be able to edit the suggestion and then accept it. This would help out in many scenarios. For example, delaying accepting a suggestion till the author fixes a typo would slow down the lesson creation/improvement process.

This would mostly involve backend changes, and a few frontend changes. Here is roughly a list of changes that would be necessary to make this work. Each of the tasks may be completed in independent PRs or they may be grouped up and completed together.

Backend - [ ] Add a service function that will allow modification of the suggestion in review. (relevant file: core/domain/suggestion_services.py) - [ ] Add a controller that will handle requests to modify a suggestion in review. Appropriate permissions need to be added to restrict who can edit the suggestion. (relevant files: core/domain/acl_decorators.py, core/controllers/suggestion.py)

Frontend - [ ] The view suggestion modal needs to be modified to also allow editing the suggestion (in the right pane).

该提问来源于开源项目:oppia/oppia

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

14条回答

  • weixin_39636099 weixin_39636099 5月前

    I will working on this.!

    点赞 评论 复制链接分享
  • weixin_39527372 weixin_39527372 5月前

    I can work on either backend part of this, can I be assigned?

    点赞 评论 复制链接分享
  • weixin_39875754 weixin_39875754 5月前

    Hi are you working on some part of this issue? If not, assigning for the backend task. Which one of the tasks would you like to take up?

    点赞 评论 复制链接分享
  • weixin_39636099 weixin_39636099 5月前

    Sure.! I will work on frontend part then

    点赞 评论 复制链接分享
  • weixin_39527372 weixin_39527372 5月前

    I can make the function to allow for the modification of the suggestion.

    点赞 评论 复制链接分享
  • weixin_39875754 weixin_39875754 5月前

    Cool, assigning you for the same.

    点赞 评论 复制链接分享
  • weixin_39890652 weixin_39890652 5月前

    how is this going?

    点赞 评论 复制链接分享
  • weixin_39636099 weixin_39636099 5月前

    working on this.! will open a PR shortly

    点赞 评论 复制链接分享
  • weixin_39527372 weixin_39527372 5月前

    Still working on it, should be done soon.

    On Mon, Oct 29, 2018 at 5:17 PM Jacob Davis wrote:

    https://github.com/hemant0308 https://github.com/wirelessfire how is this going?

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oppia/oppia/issues/5726#issuecomment-434083531, or mute the thread https://github.com/notifications/unsubscribe-auth/ApRpKKWTmh2-wvMWpYZBesBG37JBefyfks5up3BQgaJpZM4XH_58 .

    点赞 评论 复制链接分享
  • weixin_39671935 weixin_39671935 5月前

    , how is this going?

    点赞 评论 复制链接分享
  • weixin_39875754 weixin_39875754 5月前

    Hi , any updates?

    点赞 评论 复制链接分享
  • weixin_39875754 weixin_39875754 5月前

    Deassigning and due to lack of response. Assigning -keshav as he is interested to work on this issue.

    点赞 评论 复制链接分享
  • weixin_39890652 weixin_39890652 5月前

    -keshav are you still working on this?

    点赞 评论 复制链接分享
  • weixin_39900830 weixin_39900830 5月前

    Hello, I created a PR for this. And only some comments are pending to resolve. But since I am busy in my GSoC project so I leave it for now (closed the opened PR). Will come back to it and merge the PR ASAP. thanks

    点赞 评论 复制链接分享

相关推荐