weixin_39765697 2020-11-29 10:56
浏览 0

Fix/fill logs

Please provide the following details to expedite Pull Request review:

Checklist

  • [x] Checked if it requires a pylibjuju change? No
  • [x] Added integration tests for the PR? Yes
  • [x] Added or updated doc.go related to packages changed? No
  • [x] Do comments answer the question of why design decisions were made?

Description of change

Rewrite fill-unit action/function for fill-logs testing charm (previously the function write a huge amount of data into stdout causing uniter memory leak);

Driveby fix: ensure function hook commands working correctly;

QA steps

console
# bootstrap
$ juju bootstrap aws/ap-southeast-2 k1 --debug

# deploy fill-logs
$ juju add-model t1 aws && juju deploy acceptancetests/repository/charm/fill-logs --debug

# run function
$ export JUJU_DEV_FEATURE_FLAGS=juju-v3
$ juju call fill-logs/0 fill-unit megs=100 -m k1:t1 --max-wait=2m

# check log
$ juju ssh -m k1:t1 0
$ watch ls -al /var/log/juju/unit-fill-logs*

Documentation changes

No

Bug reference

No

该提问来源于开源项目:juju/juju

  • 写回答

7条回答 默认 最新

  • weixin_39765697 2020-11-29 10:56
    关注

    As discussed, we will continue to rewrite other functions of fill-logs charm in separate PRs.

    评论

报告相同问题?