Pre-commit test suite rejects diff with trailing space removed

Question

From byron.c.....com on August 02, 2014 19:01:31

There are some trailing spaces in the current code base (for example, instr.h:1979 in r2733 ), and my text editor removes them automatically. This creates a trailing space in the diff, but it is a removal of the trailing space--we want that, right? A minor change to the regex in suite/runsuite.cmake will ignore trailing spaces in lines that are being removed. I could additionally do the same for tabs, so that those can also be progressively removed from the repository.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1492

该提问来源于开源项目：DynamoRIO/dynamorio

Answer 1

From bruen....com on August 02, 2014 21:53:02

There should not be any trailing spaces or tabs in the main source files. I assume you mean r2725 . Mingwei, how did you commit trailing spaces? The pre-commit suite should have failed right up front. If it didn't then there's something wrong with its check. Please investigate.

Cc: mingwayz....com