GEODE-3609 Small AcceptorImpl refactor

Question

Use one CommunicationMode variable, not 3.

Also, refactor the selector and not-selector cases into separate methods.

I'm not changing the ServerConnectionFactory because it more or less passes straight through to ServerConnection, and there's too much legacy code there to change easily.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

• [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• [x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

• [x] Is your initial contribution a single, squashed commit?

• [x] Does gradlew build run cleanly?

• [ ] Have you written or updated unit tests to verify your changes?

• [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev.apache.org.

该提问来源于开源项目：apache/geode

Answer 1

-amurmann