New Logbook: Append .xml file extension when saving a new logbook file

Question

Describe the issue:

• [ ] Bug
• [x ] Change request
• [ ] New feature request
• [ ] Discussion request

Issue long description:

When saving a new logbook for the first time, Subsurface default is to create a XML file named by the user. The resulting file name does not have an extension.

The result is that when using the Open logbook the saved logbooks are not displayed in the dialog.

Operating system:

Not Applicable

Subsurface version:

v4.8.4

Steps to reproduce:

1. Create a New Logbook
2. Save the new logbook
3. Name the new logbook 'testing' without file extension
4. Click Save button

5. From the Subsurface File menu select Open logbook

6. At the command prompt ~/.subsurface$ ls cloudstorage googlemaps hashes printing_templates testing thumbnails

7. ~/.subsurface$ mv testing testing.xml
8. From the Subsurface File menu select Open logbook

Current behavior:

Saves the file without .xml

Expected behavior:

Saves file with .xml If .xml is supplied in naming strip the .xml from the filename to aviod testing.xml.xml

Additional information:

Mentions:

该提问来源于开源项目：subsurface/subsurface

Answer 1

Could be. Sorry I don't have a Windows.

$ uname -a Linux sean-home 4.15.0-43-generic #46-Ubuntu SMP Thu Dec 6 14:45:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux