:tophat: What? Why?
We're having many flaky failures from decidim-assemblies. The flaky comes from spec/system/private_assemblies_spec.rb:114.
After analyzing the code the assertions starting in line 111 will execute two before blocks, the one in line 85 and the one in line 105. If the first finishes after the second, the assertion in line 114 will fail.
This PR tries to solve this flaky by avoiding the execution of the before block in line 85 which is unnecessary for the current specs in 111.
:pushpin: Related Issues
Link your PR to an issue - Related to #? - Fixes #?
Testing
Describe the best way to test or validate your PR.
It is difficult to validate flaky tests but I guess that ensuring it succeeds at first attempt will mean something.
I'll try to re-run decidim-assemblies test three times at least (I'm not sure if it's possible if the test succeeds) .
:clipboard: Checklist
:rotating_light: Please review the guidelines for contributing to this repository.
- [ ] :question: CONSIDER adding a unit test if your PR resolves an issue.
- [x] :heavy_check_mark: DO check open PR's to avoid duplicates.
- [x] :heavy_check_mark: DO keep pull requests small so they can be easily reviewed.
- [x] :heavy_check_mark: DO build locally before pushing.
- [x] :heavy_check_mark: DO make sure tests pass.
- [ ] :heavy_check_mark: DO make sure any new changes are documented in
docs/. - [ ] :heavy_check_mark: DO add and modify seeds if necessary.
- [ ] :heavy_check_mark: DO add CHANGELOG upgrade notes if required.
- [ ] :heavy_check_mark: DO add to GraphQL API if there are new public fields.
- [ ] :heavy_check_mark: DO add link to MetaDecidim if it's a new feature.
- [x] :x:AVOID breaking the continuous integration build.
- [x] :x:AVOID making significant changes to the overall architecture.
:camera: Screenshots
Please add screenshots of the changes you're proposing
:hearts: Thank you!
该提问来源于开源项目：decidim/decidim
