weixin_39737317
weixin_39737317
2020-12-01 12:11

Validations - Destination Rule traffic policy override error

Describe the change Steps to reproduce: 1. Add a DR rule pointing to host *.bookinfo.svc.cluster.local enabling mtls. 2. See DR in istio-system, for example istio-telemetry

Kiali warns DR in istio-system. It shouldn't be. This PR fixes that.

Issue reference Closes https://github.com/kiali/kiali/issues/1963

该提问来源于开源项目:kiali/kiali

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39737317 weixin_39737317 5月前

    do you guys know where *.global is used and why? Because it could be a scenario to cover not only here but in whole validations.

    点赞 评论 复制链接分享
  • weixin_39622988 weixin_39622988 5月前

    do you guys know where *.global is used and why? Because it could be a scenario to cover not only here but in whole validations.

    I don't remember the "*.global", worth to check the k8s specification: https://github.com/kubernetes/dns/blob/master/docs/specification.md

    点赞 评论 复制链接分享
  • weixin_39622988 weixin_39622988 5月前

    But not sure if we need to review the whole validation. As now Destinations within DR can be anything, not only internal services names but also declared ServiceEntries.

    do you remember if we cover this case as well ?

    点赞 评论 复制链接分享
  • weixin_39633976 weixin_39633976 5月前

    We do check the ServiceEntries in other DR validations, yes.

    点赞 评论 复制链接分享

相关推荐