weixin_39984578
weixin_39984578
2020-12-01 21:10

Consider additional build validation checks

A few issues have been introduced into recent PRs

  • Locally defined versions in poms - should all be captured in top level via dependencyManagement (and potentially properties)
  • Additional exclusions from validation checks without sufficient review (used incorrectly)
  • Malformed POMs (errors occur at top so can be missed as WARNINGS)

We should consider if any of these should be made hard checks (and whether they can reasonably be) to maintain our code quality

The potential impact of these errors can vary from compile problems (as maven moves on), to bigger jars with unnnecessary dependencies, through to incompatable/breaking versions or security vulnarabilities being introduced

Opening for discussion/experimentation

original source: https://github.com/odpi/egeria/issues/1697

该提问来源于开源项目:odpi/egeria

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39984578 weixin_39984578 5月前

    Reviewed current build logs for errors/warnings & opened up #1708 #1710 #1711 #1712 #1713 #1714 #1715 #1716

    This is a first step to be able to better detect new errors/warnings introduced into the build as a regression & to set a level from where additional checks, linting etc can be done.

    点赞 评论 复制链接分享
  • weixin_39984578 weixin_39984578 5月前

    Also relates to https://github.com/odpi/egeria/issues/1417

    点赞 评论 复制链接分享
  • weixin_39778106 weixin_39778106 5月前

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

    点赞 评论 复制链接分享
  • weixin_39984578 weixin_39984578 5月前

    still valid

    点赞 评论 复制链接分享
  • weixin_39778106 weixin_39778106 5月前

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

    点赞 评论 复制链接分享
  • weixin_39984578 weixin_39984578 5月前

    No plan to action any changes here at this point -- the gradle build may offer more flexible options. so closing for now

    点赞 评论 复制链接分享

相关推荐