weixin_39877182
weixin_39877182
2020-12-01 22:38

8244418: MenuBar: IOOB exception on requestFocus on empty bar

Issue : https://bugs.openjdk.java.net/browse/JDK-8244418

Root Cause : Incorrect assumption about menu list size.

Fix : Added check for empty menu list before trying to access it.

Test : Added a unit test that fails before fix and passes after it.

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] Change must be properly reviewed

Issue

  • JDK-8244418: MenuBar: IOOB exception on requestFocus on empty bar

Reviewers

  • Jeanette Winzenburg (fastegal - Author)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/216/head:pull/216 $ git checkout pull/216

该提问来源于开源项目:openjdk/jfx

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39524147 weixin_39524147 5月前

    :wave: Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

    点赞 评论 复制链接分享
  • weixin_39966765 weixin_39966765 5月前

    Webrevs

    • 03: Full - Incremental (331766a6cefb2e43ba782c37b9f34a9a9ab7b039)
    • 02: Full - Incremental (683849c07c6d3b3fedf19ab8bba9151f5f986501)
    • 01: Full - Incremental (15c4de98e5578ed2ab6147d57d6828352ba5bd5f)
    • 00: Full (d37f9c14d60f5ac550793b94ca5989e9e0c372d9)
    点赞 评论 复制链接分享
  • weixin_39846191 weixin_39846191 5月前

    /reviewers 2

    点赞 评论 复制链接分享
  • weixin_39834780 weixin_39834780 5月前

    The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

    点赞 评论 复制链接分享
  • weixin_39834780 weixin_39834780 5月前

    This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

    
    8244418: MenuBar: IOOB exception on requestFocus on empty bar
    
    Reviewed-by: fastegal, kcr
    
    • If you would like to add a summary, use the /summary command.
    • To credit additional contributors, use the /contributor command.
    • To add additional solved issues, use the /issue command.

    Since the source branch of this PR was last updated there have been 35 commits pushed to the master branch:

    • bf2e972d5821bde1eb40851f9c752e47d8658ba1: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars
    • b2008913d7dbb3f38d006019a6e634f151496313: 8244824: TableView : Incorrect German translation
    • b2b46eb3b53ca1818843786b576d7501a909e126: 8242892: SpinnerValueFactory has an implicit no-arg constructor
    • afa805fe8b87f6d9bda60b69e9365ea521439cb7: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
    • 53042665628e169c9436ba99ecf990a6fb6918c0: 8245635: GlassPasteboard::getUTFs fails on iOS
    • ba501ef29fefbe44d7a0972b607b964b34e62242: 8246357: Allow static build of webkit library on linux
    • a02e09ddd1176b32327bc56b41af1be109fbbedc: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
    • 97499820c869c825c454740bc2ba66d4d81db0a6: 8246204: No 3D support for newer Intel graphics drivers on Linux
    • 6bd0e22d7e33a7e24f17a351914c9ab78a0c3398: 8239095: Upgrade libFFI to the latest 3.3 version
    • 853ac78ad5099ebda00dc401b3ead67cafa59aa8: 8245282: Button/Combo Behavior: memory leak on dispose
    • ... and 25 more: https://git.openjdk.java.net/jfx/compare/236e2d6e178bca976ef3b8a2a1cef1200659ba14...master

    As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate bf2e972d5821bde1eb40851f9c752e47d8658ba1.

    ➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

    点赞 评论 复制链接分享
  • weixin_39877182 weixin_39877182 5月前

    /integrate

    点赞 评论 复制链接分享
  • weixin_39834780 weixin_39834780 5月前

    The following commits have been pushed to master since your change was applied: * bf2e972d5821bde1eb40851f9c752e47d8658ba1: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars * b2008913d7dbb3f38d006019a6e634f151496313: 8244824: TableView : Incorrect German translation * b2b46eb3b53ca1818843786b576d7501a909e126: 8242892: SpinnerValueFactory has an implicit no-arg constructor * afa805fe8b87f6d9bda60b69e9365ea521439cb7: 8245575: Show the ContextMenu of input controls with long press gesture on iOS * 53042665628e169c9436ba99ecf990a6fb6918c0: 8245635: GlassPasteboard::getUTFs fails on iOS * ba501ef29fefbe44d7a0972b607b964b34e62242: 8246357: Allow static build of webkit library on linux * a02e09ddd1176b32327bc56b41af1be109fbbedc: 8246195: ListViewSkin/Behavior: misbehavior on switching skin * 97499820c869c825c454740bc2ba66d4d81db0a6: 8246204: No 3D support for newer Intel graphics drivers on Linux * 6bd0e22d7e33a7e24f17a351914c9ab78a0c3398: 8239095: Upgrade libFFI to the latest 3.3 version * 853ac78ad5099ebda00dc401b3ead67cafa59aa8: 8245282: Button/Combo Behavior: memory leak on dispose * a78b3fb50e6d42e3ae2b30cf807343bee9438981: 8242523: Update the animation and clip envelope classes * 1ab653cb5923fdc085fd5ec2f106a31979a71b5c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin * 804ccced129f4780ef4af618dd225278777e8272: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test * 9edba9cc0fcea8d097edc8c95b1360663e52f4a7: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently * 168b7f79eac065654bde25647f727a67d0029f84: 8246099: Intermittent test failures in SandboxAppTest * c41777e308f1c44f34e4fafa2006208da0f82626: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed" * 3ceee69938ebdf90dc4e7f7ff577912939144095: 8245499: Text input controls should show handles on iOS * 8914bd2a7fe442239922ceecb6678d1e17549f1e: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently * 16f446a0b950519d80fd3fa98c6da3192390d12e: 8234876: Unit test classes should not extend Application * 2d98fe6cae71673cf1de89b39846a13d9505c4c4: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE * f3190db7b21fb8a5f4b003d90f2ef2c7d7c7e738: 8244531: Tests: add support to identify recurring issues with controls et al * 1971c701aff0b5b6bb32964ffa854d47d1c80bee: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest * 6e0b45a334726b4b21a1ae2216d1932e817799e8: 8245183: Two fxml unit tests log warnings about deprecated escape sequences * a13a642defbbe72778fb97ed1c7b39929ed63297: 8244579: Windows "User Objects" leakage with WebView * 37b5edc718c7538086938712f2d69ef4690c343a: 8245456: MacPasteboard throws ClassCastException on static builds * 6e039302675fcbff34beb8cf419952e83cb5fd19: 8237602: TabPane doesn't respect order of TabPane.getTabs() list * bb2432241bcf0ec1add651b995d4ada6676b4cc3: 8244112: Skin implementations: must not violate contract of dispose * dbb64373b67c07924240aaa29cc0484d695d7eed: 8244647: Wrong first layout pass of Scrollbar controls on touch supported devices * 7b0619004af2e2d1b1a32084ef92ff5cd3880900: 8242548: Wrapped labeled controls using -fx-line-spacing cut text off * 435671ee1d7c7a5dc931e410bc6002890ab051fe: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events. * c14cc44eaa5794225a9f896123c18338eb1ac915: 8244417: support static build for Windows * b14e085862ee35493fcaad6a44411b2eaddc6026: 8244735: Error on iOS passing keys with unicode values greater than 255 * b0d66d0ded97d1a6514729dac73bc127868326da: 8242508: Upgrade to Visual Studio 2019 version 16.5.3 * 0f87d20f1d218292417597b9562a2fb224ab2c72: 8244487: One Windows 10 SDK file missing from FX build * 4ec163df90c88cc01b70d58831ad2abdb86c196d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

    Your commit was automatically rebased without conflicts.

    Pushed as commit fb962ac2631a98b8e1073a85dd9df094ba29c7ad.

    点赞 评论 复制链接分享

相关推荐