weixin_39942492
weixin_39942492
2020-12-01 22:40

Makes overlay IPv6 validation checks optional

High-level description

As of DC/OS 1.11, IPv6 overlay network is optional. Hence, the validation check shouldn't assert on the presence of IPv6 overlay. This patch makes modifies the validation checks such that IPv6 overlay could be optional

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

  • DCOS-21095 Turn IPv6 Overlay Off in IPv4 Environment

Checklist for all PRs

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
  • [ ] Test Results: [link to CI job test results for component]
  • [ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE

Instructions and review process

What is the review process and when will my changes land?

All PRs require 2 approvals using GitHub's pull request reviews.

Reviewers should be: * Developers who understand the code being modified. * Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

该提问来源于开源项目:dcos/dcos

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39947351 weixin_39947351 5月前

    This repo has -mergebot integration. You can interact with the following commands.

    
    -mergebot merge-it  
    -mergebot label [Request For Comment |Holding |Ready For Review |Work In Progress |Ship It] 
    -mergebot pr-status-checks  
    -mergebot ship_it_label_status_check  
    -mergebot override-status  
    -mergebot bump-ee  
    
    • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.
    点赞 评论 复制链接分享
  • weixin_39942492 weixin_39942492 5月前
    request for review
    
    点赞 评论 复制链接分享
  • weixin_39942492 weixin_39942492 5月前

    -mergebot bump-ee

    点赞 评论 复制链接分享
  • weixin_39947351 weixin_39947351 5月前

    Enterprise Bump PR: mesosphere/dcos-enterprise/pull/2233

    点赞 评论 复制链接分享
  • weixin_39942492 weixin_39942492 5月前

    -mergebot bump-ee

    点赞 评论 复制链接分享
  • weixin_39947351 weixin_39947351 5月前

    Enterprise Bump mesosphere/dcos-enterprise/pull/2233 updated.

    点赞 评论 复制链接分享
  • weixin_39757739 weixin_39757739 5月前

    -mergebot label [Ready For Review]

    点赞 评论 复制链接分享

相关推荐