Hi GitX people. asked me to chime in with an opinion. I'm the UI guy from AsdeqDocs, amongst other things. I've reviewed the commit. It's a curly one.
I'd say this is heading in the right direction. Open folder icons is a good usability win. The push/pull icons are no longer cryptic. I'd say the cloud icon is generally a strong idea. It's always had a meaning of 'some place out in cyberspace and you don't need to understand exactly where', even before the whole cloud computing thing hijacked the symbol. I think it works great for a remote, and is easier to get than a globe that looks a bit too much like the network settings icon.
GitX has always had a 'we just found some default icons' kind of look about it. It looks like the programmers don't care about the UI to much, which is very much not the case at all, but that's the message the old look put out there. The new look gives the product a little more of a 'cared about', finished kind of look.
I think you can still improve on the new icon set. Here's my suggestions. Firstly, the new icons don't seem to fill the available space as well as the old ones did. They seem a bit poky. I'd just try and use all those 16 points to good effect. Secondly, they lack delineation and contrast. A bit more use of colour could make it easy to understand at a glance. I'd be considering using even a white for the cloud to separate it from the folders. Thirdly, the branch icon lacks contrast in the highlighted state.
This last paragraph is my opinion only, take it or leave it.
Subjectively, while the 'flat look' is very faddish right now, and in some circumstances it rocks (like magazine style layouts), I have always found it challenging to make an interactive UI that people really connect with if it is fully flat. Most people really respond to a bit of subtle craft, making things look really well resolved and finished. As we all interact with 3d objects every day, concepts of relief, stacking, etc. will always make things look friendly and easy to use, like the real world. With these icons I'd be really tempted to add some subtle outlining or embossing, and just a few details that you hardly even see. Just to make it subtly bright and friendly.
Sorry if this is a bit disjointed, kids running riot, jumping on me, etc. better go put some of them to bed. Thanks for the great software guys, using it heaps.