weixin_39834328
weixin_39834328
2020-12-02 21:41

Jobs under QA review not showing up in Agenda

One of my jobs is under QA review as of writing (see https://github.com/zerocracy/farm/pull/1328#issuecomment-402615857). However, it's not showing up in my agenda:

image

This was supposed to be fixed in #911, with the reviewer being displayed, but it seems to be not quite completely fixed yet.

UPDATE: See https://github.com/zerocracy/farm/issues/1341#issuecomment-405849570 for the cause of the bug.

该提问来源于开源项目:zerocracy/farm

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

21条回答

  • weixin_39585463 weixin_39585463 5月前

    Changes have been merged to master in #1729, please close this issue

    点赞 评论 复制链接分享
  • weixin_39834328 weixin_39834328 5月前

    thanks

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    /z please review this job completed by /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    The job #1341 is now out of scope

    点赞 评论 复制链接分享
  • weixin_39960319 weixin_39960319 5月前

    quality good

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Order was finished, quality is "good": +35 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Quality review completed: +8 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    /z please, pay attention to this issue

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Job #1341 is now in scope, role is DEV

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Bug was reported, see §29: +15 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39834328 weixin_39834328 5月前

    this happened again in #1166, it's under QA review but not showing up in my Agenda. This is very inconsistent, a couple of days ago some of my jobs did show up in the list with the QA reviewer.

    You might be able to look at claims and other project artifacts to see if there's any pattern.

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    there are no errors in footprint:

    
        1910749580 3min "Reputation was updated" (0.25.4)
        reason: Quality review completed
        issue: 1166
        minutes: 8
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        points: 8
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review; Make payment; Award points were added
    
        1910749569 3min "Reputation was updated" (0.25.4)
        reason: Order was finished, quality is "good"
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        points: 38
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review; Make payment; Award points were added
    
        1910749567 4min "Send zold" (0.25.4)
        reason: Quality review completed
        amount:
        issue: 1166
        minutes: 8
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        recipient: ypshenychka
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review; Make payment
    
        1910749565 4min "Payment was added to debts" (0.25.4)
        reason: Quality review completed
        amount:
        issue: 1166
        minutes: 8
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review; Make payment
    
        1910748555 4min "Award points were added" (0.25.4)
        reason: Quality review completed
        issue: 1166
        minutes: 8
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        points: 8
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review; Make payment
    
        1910748552 4min "Equity transferred" (0.25.4)
        reward:
        reason: Order was finished, quality is "good"
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        vesting_rate:
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review; Make payment
    
        1910748550 4min "Send zold" (0.25.4)
        reason: Order was finished, quality is "good"
        amount:
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        recipient: carlosmiranda
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review; Make payment
    
        1910748548 4min "Payment was added to debts" (0.25.4)
        reason: Order was finished, quality is "good"
        amount:
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review; Make payment
    
        1910747547 5min "Award points were added" (0.25.4)
        reason: Order was finished, quality is "good"
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        points: 38
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review; Make payment
    
        1910747546 5min "Make payment" (0.25.4)
        reason: Quality review completed
        issue: 1166
        minutes: 8
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review
    
        1910747545 5min "Quality review completed" (0.25.4)
        issue: 1166
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review
    
        1910747544 5min "Agenda was updated" (0.25.4)
        issue: 1166
        repo: zerocracy/farm
        login: ypshenychka
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        flow: Complete QA review
    
        1910747543 5min "Make payment" (0.25.4)
        reason: Order was finished, quality is "good"
        issue: 1166
        minutes: 38
        repo: zerocracy/farm
        login: carlosmiranda
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
        cash:
        flow: Complete QA review
    
        1910747542 5min "Complete QA review" (0.25.4)
        issue: 1166
        author: ypshenychka
        repo: zerocracy/farm
        token: github;zerocracy/farm;1166;403732410
        quality: good
        comment: 403732410
        job: gh:zerocracy/farm#1166
    
        1910555406 2hr "Check job status" (0.25.3)
        issue: 1166
        author: carlosmiranda
        repo: zerocracy/farm
        token: github;zerocracy/farm;1166;403708992
        comment: 403708992
        job: gh:zerocracy/farm#1166
    
        1902163969 10hr "Job removed from WBS" (0.25.2)
        reason: Job was closed, order is finished
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        age: 9229
        flow: Close job; Finish order; Order was finished; Remove job from WBS
    
        1902161944 10hr "Remove job from WBS" (0.25.2)
        reason: Job was closed, order is finished
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        age: 9229
        flow: Close job; Finish order; Order was finished
    
        1902161943 10hr "Speed was updated" (0.25.2)
        reason: Job was closed, order is finished
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        age: 9229
        flow: Close job; Finish order; Order was finished
    
        1902161942 10hr "Agenda was updated" (0.25.2)
        reason: Job was closed, order is finished
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        age: 9229
        flow: Close job; Finish order; Order was finished
    
        1902161940 10hr "Agenda was updated" (0.25.2)
        reason: start_qa_review
        minutes: 30
        bonus:
        login: ypshenychka
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        cash:
        flow: Close job; Finish order; Start QA review
    
        1902161939 10hr "Order was finished" (0.25.2)
        reason: Job was closed, order is finished
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        flow: Close job; Finish order
        age: 9229
    
        1902161938 10hr "Start QA review" (0.25.2)
        reason: Job was closed, order is finished
        minutes: 30
        bonus:
        login: carlosmiranda
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        cash:
        flow: Close job; Finish order
    
        1902161937 10hr "Finish order" (0.25.2)
        reason: Job was closed, order is finished
        token: github;zerocracy/farm;1166
        job: gh:zerocracy/farm#1166
        flow: Close job
    
        1902146819 10hr "Close job" (0.25.2)
        reason: GitHub issue was closed
        author: krzyk
        job: gh:zerocracy/farm#1166
        token: github;zerocracy/farm;1166
    
    点赞 评论 复制链接分享
  • weixin_39834328 weixin_39834328 5月前

    I know what's causing this now. In delete_stale_jobs.groovy, Zerocracy periodically purges the Agenda list of 10 random users of jobs that are not in orders.xml. The problem is that jobs under review are actually removed in finish_order.groovy from orders.xml, and placed in reviews.xml by start_qa_review.groovy. This also explains the unpredictable behavior of this bug.

    So, delete_stale_jobs.groovy should look at both Orders and Reviews in order to ensure that the Agenda is consistent with ongoing jobs and those under QA review.

    1414 (proposed fix/workaround in PR #1440) are possibly related.

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    thanks, do you think that #1440 can also solve this issue?

    点赞 评论 复制链接分享
  • weixin_39834328 weixin_39834328 5月前

    no, since delete_stale_jobs will still be applied to DEV/REV tasks, and if they are moved from Orders to Reviews they might be nuked by the cleanup.

    点赞 评论 复制链接分享
  • weixin_39545017 IAmAngry. 5月前

    I've also noticed the problem. This is really frustrating because one day you look at the agenda and there is a job under QA review there and another day it's not there anymore.

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    assign

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    assign (here)

    The job #1341 assigned to /z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    status

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    status (here)

    This is what I know about this job in C3NDPUA8L, as in §32:

    • The job #1341 is in scope for 3mon
    • The role is DEV
    • The job is assigned to /z for 11hr
    • There is a monetary reward attached
    • /z will get 50% of their hourly rate for this job
    • Some equity will be vested on completion
    • The job doesn't have any impediments
    • The budget is 30 minutes/points
    • Job footprint (restricted area)
    点赞 评论 复制链接分享

相关推荐