weixin_39585463
weixin_39585463
2020-12-02 22:04

#1341 dont remove agenda jobs that are under review

1341

  • added exclusion for removal of agenda tests that are under review (have inspector)
  • added test for checking that agenda items under review are not removed

该提问来源于开源项目:zerocracy/farm

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

23条回答

  • weixin_39927378 weixin_39927378 5月前

    Job #1729 is now in scope, role is REV

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    This pull request #1729 is assigned to /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

    点赞 评论 复制链接分享
  • weixin_39585463 weixin_39585463 5月前

    again I got my own review

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    I see, we have a bug: #1724

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    assign

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    assign (here)

    This pull request #1729 is assigned to /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39585463 weixin_39585463 5月前

    updated, take a look

    点赞 评论 复制链接分享
  • weixin_39960116 weixin_39960116 5月前

    merge

    点赞 评论 复制链接分享
  • weixin_39740737 weixin_39740737 5月前

    merge

    Thanks for your request. Please confirm this.

    点赞 评论 复制链接分享
  • weixin_39823459 weixin_39823459 5月前

    merge

    点赞 评论 复制链接分享
  • weixin_39740737 weixin_39740737 5月前

    merge

    OK, I'll try to merge now. You can check the progress of the merge here

    点赞 评论 复制链接分享
  • weixin_39740737 weixin_39740737 5月前

    merge

    Done! FYI, the full log is here (took me 21min)

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Job was finished in 18 hours, bonus for fast delivery is possible (see §36)

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    /z please review this job completed by /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    The job #1729 is now out of scope

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39960319 weixin_39960319 5月前

    According to our QA Rules:

    The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

    Only two issues were found during code review. Please confirm that you'll try to find at least three major problems while future reviews.

    点赞 评论 复制链接分享
  • weixin_39960116 weixin_39960116 5月前

    I confirm

    点赞 评论 复制链接分享
  • weixin_39960319 weixin_39960319 5月前

    thanks

    点赞 评论 复制链接分享
  • weixin_39960319 weixin_39960319 5月前

    quality acceptable

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Order was finished, quality is "acceptable": +20 point(s) just awarded to /z

    点赞 评论 复制链接分享
  • weixin_39927378 weixin_39927378 5月前

    Quality review completed: +8 point(s) just awarded to /z

    点赞 评论 复制链接分享

相关推荐