weixin_39539733
weixin_39539733
2020-12-02 23:09

set MARATHON_DEFAULT_NETWORK_NAME to the name of the default dcos overlay network

Bug fix: Marathon should be configured with the name of the default dcos overlay network when overlay networking has been configured at install time.

该提问来源于开源项目:dcos/dcos

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

25条回答

  • weixin_39539733 weixin_39539733 5月前

    /cc

    点赞 评论 复制链接分享
  • weixin_39542850 weixin_39542850 5月前

    What does this actually do? What does "default virtual network" mean? Wouldn't this be a frontend concern?

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    it's a marathon API concern. we delivered a feature that allows Alice to ask for her app to be deployed on the default virtual network, which is configured by Dan at dcos-install time. The problem is that the dcos glue was never written to tell marathon what the default network name is.

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    hm .. still don't see my command line arg set:

    
    core-10-0-5-157 ~ $ sudo cat /proc/2472/cmdline |tr '\0' '\n'
    /opt/mesosphere/bin/java
    -Xmx2G
    -jar
    /opt/mesosphere/packages/marathon--39c9a4fd1beb5b3cc3a91892462ce46e2b54f3ed/usr/marathon.jar
    --zk
    zk://zk-1.zk:2181,zk-2.zk:2181,zk-3.zk:2181,zk-4.zk:2181,zk-5.zk:2181/marathon
    --master
    zk://zk-1.zk:2181,zk-2.zk:2181,zk-3.zk:2181,zk-4.zk:2181,zk-5.zk:2181/mesos
    --hostname
    10.0.5.157
    --default_accepted_resource_roles
    *
    --mesos_role
    slave_public
    --max_tasks_per_offer
    100
    --task_launch_timeout
    86400000
    --decline_offer_duration
    300000
    --revive_offers_for_new_apps
    --zk_compression
    --mesos_leader_ui_url
    /mesos
    --enable_features
    vips,task_killing,external_volumes
    --mesos_authentication_principal
    dcos_marathon
    --mesos_user
    root
    core-10-0-5-157 ~ $ cat /opt/mesosphere/etc/marathon 
    MARATHON_ZK=zk://zk-1.zk:2181,zk-2.zk:2181,zk-3.zk:2181,zk-4.zk:2181,zk-5.zk:2181/marathon
    
    MARATHON_DEFAULT_NETWORK_NAME=dcos
    
    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    ugh, nevermind. I thought root marathon would pull in environment variables as flags automatically. It does not. I need to change something in package/marathon

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    sweet. this latest change seems to work

    点赞 评论 复制链接分享
  • weixin_39960147 weixin_39960147 5月前

    Ping. Is this ready for review now? If so, please remove "WIP" from the title.

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    AFAIK it needs a verification function, as per the TODO in the summary. Hence WIP.

    On Tue, Nov 22, 2016 at 4:05 PM, Adam notifications.com wrote:

    https://github.com/jdef Ping. Is this ready for review now? If so, please remove "WIP" from the title.

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dcos/dcos/pull/912#issuecomment-262365470, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLOJw7k2j-LfeXSBpy0mhC1La5VJaks5rA1k3gaJpZM4Kj4J4 .

    点赞 评论 复制链接分享
  • weixin_39960147 weixin_39960147 5月前

    Ok, that shouldn't be hard. Check out validate_dcos_overlay_network in calc.py for a highly relevant example.

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    ready for review

    点赞 评论 复制链接分享
  • weixin_39847099 weixin_39847099 5月前

    every integration test failed, that suggests to me this isn't actually reviewable. Looks like pods can't be launched.

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    OK, this change has nothing to do with pods... strange

    On Tue, Dec 6, 2016 at 6:11 PM, Cody Maloney wrote:

    https://github.com/jdef every integration test failed, that suggests to me this isn't actually reviewable. Looks like pods can't be launched.

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dcos/dcos/pull/912#issuecomment-265303344, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLO9NWR7SAkAZEJ0HHEIfQ8M-YBT6ks5rFeubgaJpZM4Kj4J4 .

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    pod test failures are a bug in marathon: https://phabricator.mesosphere.com/D288

    should be fixed once marathon 1.4.0-RC2 has landed https://github.com/mesosphere/marathon/issues/4787

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    can this be added to the 1.9 milestone?

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    xref https://github.com/dcos/dcos/pull/1052

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    do we want to support the case where Dan configures NO default network (forcing Alice to be explicit w/ every network specification for an app/pod)?

    点赞 评论 复制链接分享
  • weixin_39805924 weixin_39805924 5月前

    can you do a pass on reviewing the tests here?

    点赞 评论 复制链接分享
  • weixin_39805924 weixin_39805924 5月前

    https://github.com/dcos/dcos/pull/1052 has landed

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    rebased to master

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    ready for review

    点赞 评论 复制链接分享
  • weixin_39805924 weixin_39805924 5月前

    please take a look.

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    addressed your comments, PTAL

    点赞 评论 复制链接分享
  • weixin_39748183 weixin_39748183 5月前

    can you update your reviews? Once I have approvals from two people and tests are green, it will land in the next merge train.

    点赞 评论 复制链接分享
  • weixin_39542850 weixin_39542850 5月前

    Looks reasonable to me. My only question is what happens if they enable overlay, but don't create any networks? Do we want to throw an error case for that?

    点赞 评论 复制链接分享
  • weixin_39539733 weixin_39539733 5月前

    rebased

    点赞 评论 复制链接分享

相关推荐