weixin_39624816
weixin_39624816
2020-12-02 23:20

isis: priority of isis commands in interface configuration

(issue #4028) Priority of isis commands in configuration mattered. Need to show ip[v6] router isis in before any other commands in the running config for interfaces configuration.

Signed-off-by: Dmitrii Turlupov

该提问来源于开源项目:FRRouting/frr

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

24条回答

  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 c25ae456 Date | 04/01/2019 Start | 10:00:27 Finish | 10:24:30 Run-Time | 24:03 Total | 1816 Pass | 1816 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-04-01-10:00:27.txt Log | autoscript-2019-04-01-10:01:13.log.bz2 Memory | 498 494 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Checkout code: Successful with additional warnings Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-30537/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-30537/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-30537/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-30537/isis_redist.c:652:

    Warnings Generated during build:

    Ubuntu 16.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/CI014BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 18.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 18.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/U1804AMD64/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 16.04 i386 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 i386 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/U1604I386/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80 Debian 9 amd64 build: Successful with additional warnings __Debian Package lintian failed for Debian 9 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/CI021BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80 Ubuntu 14.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 14.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/CI001BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7095/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39944515 weixin_39944515 5月前

    CI:rerun

    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7141/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Checkout code: Successful with additional warnings Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-27599/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-27599/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-27599/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-27599/isis_redist.c:652:

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7141/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 4fc23a23 Date | 04/05/2019 Start | 06:30:25 Finish | 06:55:14 Run-Time | 24:49 Total | 1816 Pass | 1816 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-04-05-06:30:25.txt Log | autoscript-2019-04-05-06:31:11.log.bz2 Memory | 494 481 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7155/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Checkout code: Successful with additional warnings Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-26529/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-26529/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-26529/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-26529/isis_redist.c:652:

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7155/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39982568 weixin_39982568 5月前

    Looking good now, only a few last requests: * You also need to update vty_print_def_origin() as well to show the metric only when necessary (if (show_defaults || !yang_dnode_is_default(dnode, "./metric")). * Please squash the last four commits into a single one, since they solve the same problem and are easier to review when combined (if you prefer you can leave the fabricd changes in a separate commit). * Change the commit message of your first commit to describe what problem it's solving (need to show ip[v6] router isis before any other commands in the running config).

    点赞 评论 复制链接分享
  • weixin_39624816 weixin_39624816 5月前
    * You also need to update `vty_print_def_origin()` as well to show the metric only when necessary (`if (show_defaults || !yang_dnode_is_default(dnode, "./metric")`).
    

    But code already exist:

    `
    if (yang_dnode_exists(dnode, "./metric")) {
        metric = yang_dnode_get_string(dnode, "./metric");
        if (show_defaults || !yang_dnode_is_default(dnode, "./metric"))
            vty_out(vty, " metric %s", metric);
    }
    

    `

    点赞 评论 复制链接分享
  • weixin_39982568 weixin_39982568 5月前

    
    * You also need to update <code>vty_print_def_origin() as well to show the metric only when necessary (if (show_defaults || !yang_dnode_is_default(dnode, "./metric")).
    

    But code already exist:

    
    if (yang_dnode_exists(dnode, "./metric")) {
      metric = yang_dnode_get_string(dnode, "./metric");
      if (show_defaults || !yang_dnode_is_default(dnode, "./metric"))
          vty_out(vty, " metric %s", metric);
    }
    

    With your changes, metric will have a default value now, so it will always exist. So you should display the metric only if its value is different from the default value (zero) or if the configuration is being displayed with the with-defaults option (which is only available in the transactional CLI mode).

    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: FAILED

    See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7164/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Get source / Pull Request: Successful

    Building Stage: Failed

    CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: No useful log found Successful on other platforms - Debian 8 amd64 build - FreeBSD 11 amd64 build - OpenBSD 6 amd64 build - NetBSD 6 amd64 build - Ubuntu 18.04 amd64 build - Debian 9 amd64 build - OmniOS amd64 build - CentOS 6 amd64 build - NetBSD 7 amd64 build - Ubuntu 16.04 amd64 build - Ubuntu 12.04 amd64 build - FreeBSD 10 amd64 build - Ubuntu 14.04 amd64 build - Ubuntu 16.04 i386 build

    Warnings Generated during build:

    Checkout code: Successful with additional warnings CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: No useful log found Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-27434/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-27434/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-27434/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-27434/isis_redist.c:652:
    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 a073a971 Date | 04/05/2019 Start | 12:15:21 Finish | 12:39:10 Run-Time | 23:49 Total | 1816 Pass | 1816 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-04-05-12:15:21.txt Log | autoscript-2019-04-05-12:16:05.log.bz2 Memory | 501 495 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7166/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Checkout code: Successful with additional warnings Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-4512/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-4512/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-4512/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-4512/isis_redist.c:652:

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7166/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39982568 weixin_39982568 5月前

    I took the liberty to rebase your changes in order to better organize your commits. This PR should be ready to go now.

    Thanks a lot for your contributions!

    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 ee22b196 Date | 04/15/2019 Start | 20:55:21 Finish | 21:19:09 Run-Time | 23:48 Total | 1813 Pass | 1813 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-04-15-20:55:21.txt Log | autoscript-2019-04-15-20:56:05.log.bz2 Memory | 499 496 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7246/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Checkout code: Successful with additional warnings Report for isis_redist.c | 8 issues =============================================== < WARNING: braces {} are not necessary for single statement blocks < #559: FILE: /tmp/f1-10553/isis_redist.c:559: < WARNING: braces {} are not necessary for single statement blocks < #564: FILE: /tmp/f1-10553/isis_redist.c:564: < WARNING: braces {} are not necessary for single statement blocks < #647: FILE: /tmp/f1-10553/isis_redist.c:647: < WARNING: braces {} are not necessary for single statement blocks < #652: FILE: /tmp/f1-10553/isis_redist.c:652:

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 586d378

    No Changes in Static Analysis warnings compared to base

    14 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7246/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 371a31c0 Date | 03/27/2019 Start | 09:23:58 Finish | 09:47:44 Run-Time | 23:46 Total | 1816 Pass | 1816 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-03-27-09:23:58.txt Log | autoscript-2019-03-27-09:24:43.log.bz2 Memory | 496 489 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: FAILED

    See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Get source / Pull Request: Successful

    Building Stage: Successful

    Basic Tests: Failed

    Topology tests on Ubuntu 16.04 amd64: Failed (click for details) Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7048/test __Topology Tests failed for Topology tests on Ubuntu 16.04 amd64__: *** defaultIntf: warning: r1 has no interfaces 2019-03-27 06:34:29,855 ERROR: 'router_json_cmp' failed after 102.80 seconds 2019-03-27 06:34:29,862 ERROR: assert failed at "test_ldp_vpls_topo1/test_ldp_bindings": "r1" JSON output mismatches the expected result assert json value is different ( --- Expected value +++ Current value @@ -21 +21 @@ - "localLabel": "17", + "localLabel": "18", @@ -29 +29 @@ - "localLabel": "17", + "localLabel": "18", @@ -37 +37 @@ - "localLabel": "18", + "localLabel": "17", @@ -45 +45 @@ - "localLabel": "18", + "localLabel": "17", ) *** defaultIntf: warning: lm has no interfaces see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/TOPOU1604/ErrorLog/log_topotests.txt Successful on other platforms - IPv4 ldp protocol on Ubuntu 16.04 - Ubuntu 14.04 deb pkg check - Debian 8 deb pkg check - Addresssanitizer topotest - IPv4 protocols on Ubuntu 14.04 - Debian 9 deb pkg check - Topotest tests on Ubuntu 16.04 i386 - CentOS 7 rpm pkg check - Static analyzer (clang) - Ubuntu 12.04 deb pkg check - Ubuntu 16.04 deb pkg check - IPv6 protocols on Ubuntu 14.04 - Topology tests on Ubuntu 18.04 amd64 - CentOS 6 rpm pkg check

    Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/TOPOU1604/MemoryLeaks/

    Warnings Generated during build:

    Ubuntu 16.04 i386 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 i386 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/U1604I386/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80 Ubuntu 16.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI014BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 18.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 18.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/U1804AMD64/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Debian 9 amd64 build: Successful with additional warnings __Debian Package lintian failed for Debian 9 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI021BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80 Ubuntu 14.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 14.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI001BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af
    • Base image data for Git 13551af does not exist - compare skipped

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Ubuntu 16.04 i386 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 i386 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/U1604I386/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80 Ubuntu 16.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI014BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 18.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 18.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/U1804AMD64/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Debian 9 amd64 build: Successful with additional warnings __Debian Package lintian failed for Debian 9 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI021BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80 Ubuntu 14.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 14.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/CI001BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af
    • Base image data for Git 13551af does not exist - compare skipped

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7048/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39867559 weixin_39867559 5月前

    LGTM, didn't even realize that order mattered when writing configuration, I should have guess it / tried it.

    it's probably a good idea to document this for the people who will convert more daemons in the future, what do you reckon?

    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 e51dbb82 Date | 03/29/2019 Start | 07:20:21 Finish | 07:44:44 Run-Time | 24:23 Total | 1813 Pass | 1813 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-03-29-07:20:21.txt Log | autoscript-2019-03-29-07:21:21.log.bz2 Memory | 494 495 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: SUCCESSFUL

    Congratulations, this patch passed basic tests

    Tested-by: NetDEF / OpenSourceRouting.org CI System

    CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Warnings Generated during build:

    Ubuntu 18.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 18.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/U1804AMD64/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 14.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 14.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/CI001BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Debian 9 amd64 build: Successful with additional warnings __Debian Package lintian failed for Debian 9 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/CI021BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80 Ubuntu 16.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/CI014BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 16.04 i386 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 i386 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/U1604I386/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7074/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享
  • weixin_39982568 weixin_39982568 5月前

    thanks for reporting and fixing this problem.

    When the transactional CLI mode is not being used, the order of the commands matters, so we should care about this.

    The nb_cli_show_dnode_cmds() function displays the configuration nodes following the order they appear in the YANG modules. So from that point of view your fix is correct. If necessary, in the future we can add a new property like cli_order to the nb_node struct so that the CLI command ordering information can be specified in the code and not in the YANG modules. That would probably be a cleaner solution, but would add some overhead when displaying configurations as we'd need to do some buffering in order to order the commands ourselves. For now let's keep things simple and order the configuration nodes as necessary in the YANG modules (hence I approve your first commit).

    Indeed, I'll update the Retrofitting Configuration Commands page accordingly later.

    点赞 评论 复制链接分享
  • weixin_39950764 weixin_39950764 5月前

    💚 Basic BGPD CI results: SUCCESS, 0 tests failed

    Results table _|_ -|- Result | SUCCESS git merge/4029 7ad86a4d Date | 03/29/2019 Start | 11:30:21 Finish | 11:54:09 Run-Time | 23:48 Total | 1816 Pass | 1816 Fail | 0 Valgrind-Errors | 0 Valgrind-Loss | 0 Details | vncregress-2019-03-29-11:30:21.txt Log | autoscript-2019-03-29-11:31:06.log.bz2 Memory | 495 493 429 For details, please contact louberger
    点赞 评论 复制链接分享
  • weixin_39629075 weixin_39629075 5月前

    Continuous Integration Result: FAILED

    See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/

    This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

    Get source / Pull Request: Successful

    Building Stage: Successful

    Basic Tests: Failed

    Topotest tests on Ubuntu 16.04 i386: Failed (click for details) Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7078/test __Topology Tests failed for Topotest tests on Ubuntu 16.04 i386__: *** defaultIntf: warning: r1 has no interfaces RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument *** defaultIntf: warning: lm has no interfaces r2: ospfd crashed. Core file found - Backtrace follows: [New LWP 17790] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1". Core was generated by `/usr/lib/frr/ospfd'. Program terminated with signal SIGABRT, Aborted. #0 0xb7f93d05 in ?? () #0 0xb7f93d05 in ?? () #1 0x004dcd82 in ?? () #2 0xb7f359d9 in thread_call () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0 #3 0xb7f07c01 in frr_run () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0 #4 0x004c4f16 in main () 2019-03-29 09:06:26,046 ERROR: assert failed at "test_ospf_sr_topo1/test_memory_leak": r2: ospfd crashed. Core file found - Backtrace follows: [New LWP 17790] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1". Core was generated by `/usr/lib/frr/ospfd'. Program terminated with signal SIGABRT, Aborted. #0 0xb7f93d05 in ?? () #0 0xb7f93d05 in ?? () #1 0x004dcd82 in ?? () #2 0xb7f359d9 in thread_call () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0 #3 0xb7f07c01 in frr_run () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0 #4 0x004c4f16 in main () RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument RTNETLINK answers: Invalid argument see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/TOPOI386/ErrorLog/log_topotests.txt Successful on other platforms - Addresssanitizer topotest - Debian 8 deb pkg check - Debian 9 deb pkg check - Topology tests on Ubuntu 16.04 amd64 - IPv4 protocols on Ubuntu 14.04 - Ubuntu 14.04 deb pkg check - IPv4 ldp protocol on Ubuntu 16.04 - Static analyzer (clang) - CentOS 7 rpm pkg check - Topology tests on Ubuntu 18.04 amd64 - IPv6 protocols on Ubuntu 14.04 - Ubuntu 16.04 deb pkg check - Ubuntu 12.04 deb pkg check - CentOS 6 rpm pkg check

    Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/TOPOI386/MemoryLeaks/

    Warnings Generated during build:

    Ubuntu 16.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/CI014BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 14.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 14.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/CI001BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Ubuntu 16.04 i386 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 16.04 i386 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/U1604I386/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80 Ubuntu 18.04 amd64 build: Successful with additional warnings __Debian Package lintian failed for Ubuntu 18.04 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/U1804AMD64/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80 Debian 9 amd64 build: Successful with additional warnings __Debian Package lintian failed for Debian 9 amd64 build__: (see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/CI021BUILD/ErrorLog/log_lintian.txt) W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80

    CLANG Static Analyzer Summary

    • Github Pull Request 4029, comparing to Git base SHA 13551af

    No Changes in Static Analysis warnings compared to base

    1 Static Analyzer issues remaining.

    See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7078/artifact/shared/static_analysis/index.html

    点赞 评论 复制链接分享

相关推荐