weixin_39700625
weixin_39700625
2020-12-04 16:38

gdal version macro < gdal 1.10

With gdal 1.10.0 (Released in April 2013) the current "GDAL Version Information macro" was introduced. Older versions used a different version of the macro. The current version of Fiona does only follow the new macro definition. However, the documentation says that GDAL/OGR 1.8+ is supported. This PR makes calc_gdal_version_num and get_gdal_version_tuple aware of the different GDAL Version Information macro for OGR versions prior to 1.10.0.

I'm not sure if there are users that use a recent version of Fiona in combination with such an old version of gdal/ogr. Thus we could also just bump the minimal supported version of gdal to 1.10.

However, we currently do not test in the CI for backwards compability to the oldest supported version of gdal/ogr, which might be something that we should do (thus, this PR will not be tested by the CI).

该提问来源于开源项目:Toblerity/Fiona

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39629969 weixin_39629969 5月前

    Coverage Status

    Coverage decreased (-0.4%) to 84.081% when pulling 80202e46127df80063798b32ec445739301a462c on rbuffat:gdal_before_1_10_comapt into ef534ac4b0c15f5634d91ef91f18cf9f8d723d53 on Toblerity:master.

    点赞 评论 复制链接分享
  • weixin_39629969 weixin_39629969 5月前

    Coverage Status

    Coverage decreased (-0.4%) to 84.081% when pulling 80202e46127df80063798b32ec445739301a462c on rbuffat:gdal_before_1_10_comapt into ef534ac4b0c15f5634d91ef91f18cf9f8d723d53 on Toblerity:master.

    点赞 评论 复制链接分享
  • weixin_39629969 weixin_39629969 5月前

    Coverage Status

    Coverage decreased (-0.4%) to 84.081% when pulling 80202e46127df80063798b32ec445739301a462c on rbuffat:gdal_before_1_10_comapt into ef534ac4b0c15f5634d91ef91f18cf9f8d723d53 on Toblerity:master.

    点赞 评论 复制链接分享
  • weixin_39657249 weixin_39657249 5月前

    Great! I don't see any harm in merging this.

    点赞 评论 复制链接分享

相关推荐