I've lived through several iterations of these specifications and their respective tools, and some of these changes seem arbitrary...
Update Version entry (Keyword key was introduced in 1.1)
Ok, we're using Desktop Entry Specification v1.1 now.
The page shows "Version 1.2alpha"... that casts doubt on the stability of these specifications.
rawtherapee.desktop and changed
Version=1.1, then validated it:
text $ desktop-file-validate --help (...) Validate desktop entry files according to the Desktop Entry specification 1.1. $ desktop-file-validate rawtherapee.desktop $ echo $? 0
It validates. A look inside
.desktop files on my computer shows the case of the
GenericName field is mixed - more often capitalized than not, but no rule for that in the specification, and no explanation of what a "generic name" even is. So the
GenericName value is changed, but not fixed, since it's not broken.
bash /usr/share/applications/org.kde.mobile.okular_pdf.desktop:GenericName=Document viewer /usr/share/applications/displaycal-apply-profiles.desktop:GenericName=Calibration and ICC Profile Loader (force) /usr/share/applications/org.kde.mobile.okular_xps.desktop:GenericName=Document viewer /usr/share/applications/displaycal-curve-viewer.desktop:GenericName=Calibration and ICC profile tone response curve viewer /usr/share/applications/org.kde.mobile.okular_fb.desktop:GenericName=Document viewer etc.
Agreed with the rest of the changes to the
Fix description (
I don't mind the change, but it's not broken, and the way we have it is the way the specification uses it.
Remove keywords (should be obtained from desktop file)
I don't mind the change, but as before, they're not broken.
Fix screenshot caption (too long)
The specification says the caption's max length is 180 chars, not 50:
Optionally, a tag may have achild, defining a short (not more than 180 characters!) description of what the user can see on the referenced screenshot.
Try not to repeat the application's name in the caption.
Most of the captions contain the word "RawTherapee", so they need to be "fixed".
One of the screenshot's URL no long works due to switching websites.
Here is a new screenshots section to replace the current one:
<screenshots> <screenshot type="default"> <caption>Color correction</caption> <image width="1920" height="1080">https://rawtherapee.com/images/screenshots/rt57_drosera_rotundifolia.png</image> </screenshot> <screenshot> <caption>File browser</caption> <image width="1920" height="1080">https://rawtherapee.com/images/screenshots/rt57_file_browser.png</image> </screenshot> <screenshot type="default"> <caption>High dynamic range compression</caption> <image width="1920" height="1080">https://rawtherapee.com/images/screenshots/rt57_field_sunset.png</image> </screenshot> <screenshot type="default"> <caption>Developing a film negative</caption> <image width="1920" height="1080">https://rawtherapee.com/images/screenshots/rt57_film_negative.png</image> </screenshot> </screenshots>