2020-12-07 09:57 阅读 2

add alias nana::nana in CMakeLists.txt

This commit adds the alias to allow the use of nana::nana in other projects as per guideline https://gist.github.com/mbinna/c61dbb39bca0e4fb7d1f73b0d66a4fd1#using-a-library-defined-in-the-same-cmake-tree-should-look-the-same-as-using-an-external-library.

This change should not break anything, it only adds an alternative name


  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

4条回答 默认 最新

  • weixin_39555320 weixin_39555320 2020-12-07 09:57

    relates to #438

    点赞 评论 复制链接分享
  • weixin_39979332 weixin_39979332 2020-12-07 09:57

    Hi , this is OK. I have some reserve about the convenience of sopporting consuming precompilied libraries, but well... Anyway, please read the nana readme this part:

    Sending a Pull Request ? This project encourage you to contribute through sending a pull request! There is a simple rule: please don't directly commit your contributions to the master branch. According to your commits, please choose the hotfixes branch or the develop branch. Thank you!

    And yes: thank you for your interest in nana!! By the way: did you saw how travis tested nana by RUNNING most of the examples with your own PR? https://travis-ci.org/cnjinhao/nana/builds/539125555?utm_source=github_status&utm_medium=notification look at that detailed - is very interesting

    点赞 评论 复制链接分享
  • weixin_39555320 weixin_39555320 2020-12-07 09:57

    I have changed the PR to push to develop

    点赞 评论 复制链接分享
  • weixin_39949954 weixin_39949954 2020-12-07 09:57

    Thanks for your PR!

    点赞 评论 复制链接分享