weixin_39731682
weixin_39731682
2020-12-07 11:32

sleep to ensure dashboard/webhook are ready

该提问来源于开源项目:FairwindsOps/polaris

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39945679 weixin_39945679 5月前

    Codecov Report

    Merging #189 into master will not change coverage. The diff coverage is n/a.

    Impacted file tree graph

    diff
    @@           Coverage Diff           @@
    ##           master     #189   +/-   ##
    =======================================
      Coverage   82.84%   82.84%           
    =======================================
      Files          10       10           
      Lines         647      647           
    =======================================
      Hits          536      536           
      Misses         87       87           
      Partials       24       24
    

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 467ab94...0313973. Read the comment docs.

    点赞 评论 复制链接分享
  • weixin_39611506 weixin_39611506 5月前

    Is this something that's just impossible to determine in code or is this a band-aid for a longer solution that we have an open issue for?

    点赞 评论 复制链接分享
  • weixin_39731682 weixin_39731682 5月前

    For the webhook, there might be a better solution if we add a readiness listener.

    For go run main.go --dashboard, we might be able to add some log output, and wait for that to appear.

    For the dashboard, where we have to run port-forward, I'm not sure if there's a good solution, but we might be able to wait for log output there as well.

    点赞 评论 复制链接分享
  • weixin_39731682 weixin_39731682 5月前

    Opened https://github.com/FairwindsOps/polaris/issues/191 to track

    点赞 评论 复制链接分享

相关推荐