2020-12-08 18:41 阅读 1

Add FromName and ReplyTo properties to SmtpSettingsPart

Refer to : - https://stackoverflow.com/a/14555043/1872200 and - https://www.postmastery.com/list-unsubscribe-header-critical-for-sustained-email-delivery/

I think adding from name, reply to and List-Unsubscribe can help passing an email spam filter.

Therefore, I have updated SmtpSettingsPart to include FromName, ReplyTo and ListUnsubscribe properties. In addition, I also updated SmtpMessageChannel to make sure everything work correctly.

BTW, I have changed naming convention of fields to not use _ underscore and use a this keyword. I know it is more convenient to use underscore but I think it is not .NET naming convention.

Hopefully, this PR is valid and will get approved. I am happy to update this PR from your feedback.



  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

4条回答 默认 最新

  • weixin_39975683 weixin_39975683 2020-12-08 18:41

    Can you also check that the workflow activities don't need to be updated to support these new fields?

    I am not familiar with Orchard.WorkFlow area. However after I search carefully, I did not find any usage of SMTP setting here. image

    There are two main places that use the setting. - EmailMessagingChannel I don't update it because it is obsoleted. - SmtpMessageChannel the main file that I changed.

    点赞 评论 复制链接分享
  • weixin_39975683 weixin_39975683 2020-12-08 18:41

    Fixed all from your feedback, thank you so much.

    点赞 评论 复制链接分享
  • weixin_39975683 weixin_39975683 2020-12-08 18:41

    Fixed all your PR feedbacks. Thanks.

    点赞 评论 复制链接分享
  • weixin_39875516 weixin_39875516 2020-12-08 18:41

    Tagging us here to review our email activities/workflows

    点赞 评论 复制链接分享