weixin_39523887
weixin_39523887
2020-12-08 18:52

Windows: Use the application icon for the sidebar

By setting the icon in Desktop.ini of the root folder, this adds the icon both when browsing the folder directly and to the sidebar shortcut.

To avoid overwriting any user setting that could exist in Desktop.ini, only do this if the file doesn't exist. Editing .ini files on Windows isn't trivial and isn't worth it given that this file won't exist most of the time.

Fixes #2446

该提问来源于开源项目:owncloud/client

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39523887 weixin_39523887 5月前

    One thing to think about: do we allow the default ignore list to be edited in order to allow syncing Desktop.ini files? This would mean that every new device starting to sync a folder would probably propagate its new Desktop.ini to other machines (possibly with an icon path that won't work for them).

    点赞 评论 复制链接分享
  • weixin_39523887 weixin_39523887 5月前

    I also added b5a1270 to hardcode the desktop.ini exclusion, could you quickly review?

    点赞 评论 复制链接分享
  • weixin_39589766 weixin_39589766 5月前

    Could you harmonize Desktop.ini vs desktop.ini to whatever Windows normally does? I know it doesn't really play a role on Windows, but still :/

    (btw, does csync_fnmatch watch case?)

    点赞 评论 复制链接分享
  • weixin_39523887 weixin_39523887 5月前

    Thanks, I was waiting for the CI to pass, the previous build didn't pass.

    点赞 评论 复制链接分享

相关推荐