2020-12-08 19:52

Under review: Align admin attributes_preview with catalog

Changes have been made to the store side attributes display file but have not been carried over to the admin "equivalent". This aligns them.


  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答


  • weixin_39851457 weixin_39851457 5月前

    In v160 we removed the attributes-preview altogether ... because it can't really ever display the same as it does catalog-side.

    Any objection to removing it in 156 too?

    点赞 评论 复制链接分享
  • weixin_39954464 weixin_39954464 5月前

    😏 I already removed the link in my refactored attibutes_controller.php file

    点赞 评论 复制链接分享
  • weixin_39632728 weixin_39632728 5月前

    Well, I had noticed that functionally the attributes_preview provided incorrect information which was some of the same incorrect information presented on the attributes_controller and the product pages but some of those issues are being resolved through #1404. That coupled with the lack of "support" by plugins to consider the potential of seeing how the attributes will be populated. (preview "format" certainly doesn't display like it does on a product page, but then again a product page "preview" as written/provided won't necessarily work either if a product to be previewed is disabled.)

    I did notice the preview was removed from the attributes_controller, but didn't stop me from trying to bring the code up to snuff in absence of the link from the attributes_controller page.

    I don't know of anything specific that must have the feature, It seems though that it is being removed for the wrong reason and without an equivalent replacement/option (unless I missed seeing a link that would specifically display the product as seen on the store front.)

    If it's destined to be removed, might as well start sooner rather than later so that either those that miss it can speak up and/or find a solution that works for them. Obviously prefer something being said as can't read minds. :)

    点赞 评论 复制链接分享
  • weixin_39851457 weixin_39851457 5月前

    Agreed: removal "just because" isn't always fair.

    It was removed in 160 because of its non-parity to catalog and complete inability to ever make it be so, without refactoring it to be a modal/popup that pulls in the entire catalog-template using substituted previewable variables. Humongous task.

    Similar reason for targeting removal of admin "preview" page for products .. something which I don't think we've committed to 160 yet. The preview doesn't serve much of a purpose, other than to be "one extra step" every time someone updates a product. (It has a technical dependency in that it facilitates uploading of files, but that can be reworked.)

    点赞 评论 复制链接分享