weixin_39726044
weixin_39726044
2020-12-08 22:46

Try moving build to just gulp

This PR is a proposal for how to fulfill https://github.com/github/vscode-codeql/issues/498. All build configuration is moved into extensions/ql-vscode and now only one buildable module exists, so we don't use rush anymore. The Actions workflow files call gulp directly. Building the package with vsce seems to remove devDependencies just fine by itself, so we no longer have to do any traversal of our dependencies, just copy node_modules to the dist directory and let vsce do its thing.

In fact, the only reason we have to create a distribution directory and copy anything at all is because we fiddle with the version number in package.json. But this seems fine --- it lets us have exact control over which files go in the package. But maybe vsce pays attention to the "files" section in package.json, I haven't checked that.

该提问来源于开源项目:github/vscode-codeql

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39726044 weixin_39726044 4月前

    (for a sense of scale, this diff is +196 loc, -3116 loc excluding the shrinkwrap/lock files)

    点赞 评论 复制链接分享
  • weixin_39726044 weixin_39726044 4月前

    absolutely; that seems like the immediate next step. I only postponed it because this is plenty big and it seemed less deeply consequential (although it requires changing some relative paths in a few files iirc)

    点赞 评论 复制链接分享
  • weixin_39780962 weixin_39780962 4月前

    NIce.

    点赞 评论 复制链接分享
  • weixin_39726044 weixin_39726044 4月前

    Still need to fix CONTRIBUTING.md now.

    点赞 评论 复制链接分享

相关推荐