weixin_39827798
weixin_39827798
2020-12-08 23:29

Windows compilation

This fixes Windows compilation locally. PTAL too! There are still a bunch of warnings on Windows that we should remove incrementally.

This still misses one fix for nxtcpp.h's ObjectBase that will be in the validation test PR.

该提问来源于开源项目:googlearchive/nxt-standalone

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39827798 weixin_39827798 5月前

    You are right, the move semantics were broken, and it didn't show up in Linux or Mac builds due to how compilers generate or not move constructions.

    The fixes for this are in https://github.com/google/nxt-standalone/pull/22/commits/4d8857f5f7f1fb2766d2b46a6b88edeb58ad2853 Sorry I should have been more clear in the first comment.

    点赞 评论 复制链接分享
  • weixin_39827798 weixin_39827798 5月前

    And you are right that the move constructor shouldn't need to release, I'll fix that.

    点赞 评论 复制链接分享
  • weixin_39917291 weixin_39917291 5月前

    LGTM. Any chance we could add some more warning flags (-pedantic in particular) to help make sure that we don't accidentally break the build on other platforms?

    (Doesn't have to be in this PR, just something I would really like to have now that we're developing on more than one compiler. Other warnings would be good too but probably harder to clean up. If you'd like I can try to make this switch, LMK.)

    点赞 评论 复制链接分享
  • weixin_39827798 weixin_39827798 5月前

    Thanks for the review, I'll look at setting up travis and Appveyor soon so we get compilation and unittests tested on every PR.

    点赞 评论 复制链接分享

相关推荐